Skip to content

Make "--unshare-user-try" check if /proc is mounted with hidepid #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madaidan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make "--unshare-user-try" check if /proc is mounted with hidepid #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions bubblewrap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2227,6 +2227,15 @@ main (int argc,
if (max_user_ns != NULL && strcmp(max_user_ns, "0\n") == 0)
disabled = TRUE;
}

/* Check if /proc is mounted with hidepid=1 or hidepid=2 */
if (stat ("/proc/mounts", &sbuf) == 0)
{
cleanup_free char *hidepid = NULL;
hidepid = load_file_at (AT_FDCWD, "/proc/mounts");
if (strstr(hidepid, "hidepid=") != NULL)
disabled = TRUE;
}

/* Debian lets you disable *unprivileged* user namespaces. However this is not
a problem if we're privileged, and if we're not opt_unshare_user is TRUE
Expand Down