refactor: subdirectory layout, mod.nu entry point, test suite by danielbodnar · Pull Request #1 · danielbodnar/dagger.nu

danielbodnar · 2026-02-28T18:29:33Z

Summary

Moves dagger.nu → completions/dagger.nu to make room for future commands, modules, etc.
Adds mod.nu root entry point following the nushell-modules pattern (export use completions/dagger.nu *)
Adds tests/completions.test.nu with 13 passing tests

Test suite covers

Category	Tests
Helper values	sdks, progress formats, compat, shell names, SPDX licenses, LLM models, subcommands, toolchain subcommands
Descriptions	Every table-form helper must have non-empty descriptions
Extern registration	All 17 top-level + 5 toolchain externs registered after `use`
Uniqueness	No duplicate externs or completion values
Integration	`mod.nu` correctly re-exports everything

Design note: `export def` for `nu-complete` helpers

The reference nushell-modules repo uses non-exported helpers. For this completions-focused repo, export def is the right call — the helpers are the public API (users can call nu-complete dagger sdks | get value to inspect options). This also avoids subshell gymnastics in tests.

Install path change

# Before
use /path/to/dagger.nu *

# After
use /path/to/dagger.nu/mod.nu *
# or
use /path/to/dagger.nu/completions/dagger.nu *

- completions/dagger.nu: move from root, export nu-complete helpers - tests/completions.test.nu: 12 tests covering all completion helpers and registered extern commands (std/assert, no mutable closures) - README: update install path

nu-complete helpers are exported (export def) — appropriate for a completions module where helpers are part of the public API. Tests use top-level `use` so scope commands reflects parser-time scope and helpers are callable without subshell gymnastics. Also adds mod.nu entry point following nushell-modules convention.

Copilot

Pull request overview

Refactors the repository into a more nushell-module-friendly layout by introducing a root mod.nu entrypoint, moving the completions into a subdirectory, and adding a Nushell test suite to validate exported helpers/externs and re-export behavior.

Changes:

Add mod.nu as the root module entrypoint that re-exports the completions module.
Export nu-complete helper defs from completions/dagger.nu and add a new tests/completions.test.nu suite.
Update README manual install instructions to reflect the new file layout.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`tests/completions.test.nu`	Adds a Nushell test runner validating helper outputs, extern registration, uniqueness, and `mod.nu` integration.
`mod.nu`	Introduces root entrypoint that `export use`s the completions module.
`completions/dagger.nu`	Switches completion helper defs to `export def` to make them part of the module’s public surface.
`README.md`	Updates manual installation guidance for the new directory layout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-01T02:47:36Z

+    let out = ^nu --no-config-file -c $"
+        use '/workspaces/code/github.com/danielbodnar/dagger.nu/mod.nu' *


test mod.nu entry point hard-codes an absolute workspace path (/workspaces/code/github.com/danielbodnar/dagger.nu/mod.nu). This will fail for anyone running the tests outside that specific directory layout (CI, local clones, Windows). Compute the module path dynamically from the test file location (e.g., via $env.FILE_PWD + path join + path expand) and interpolate that into the ^nu -c string instead of embedding a fixed path.

Suggested change

let out = ^nu --no-config-file -c $"

use '/workspaces/code/github.com/danielbodnar/dagger.nu/mod.nu' *

let mod-path = ([$env.FILE_PWD ".." "mod.nu"] | path join | path expand)

let out = ^nu --no-config-file -c $"

use '($mod-path)' *

Copilot · 2026-03-01T02:47:37Z

+Clone the repo, then add to `config.nu`:

 ```nushell
-use dagger.nu *
-```
-
-Or source it directly:
-
-```nushell
-use /path/to/dagger.nu *
+use /path/to/dagger.nu/completions/dagger.nu *
 ```


README manual install now points users at use /path/to/dagger.nu/completions/dagger.nu *, but this PR introduces mod.nu specifically as the stable root entry point. Consider updating the README to recommend use /path/to/dagger.nu/mod.nu * (and optionally mention the completions file as an alternative) to keep documentation consistent with the new layout and intended public entrypoint.

danielbodnar · 2026-03-21T03:57:29Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-03-21T03:57:38Z

@danielbodnar I've opened a new pull request, #2, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: danielbodnar <1790726+danielbodnar@users.noreply.github.com> Agent-Logs-Url: https://github.com/danielbodnar/dagger.nu/sessions/af9bae3d-4462-46d8-9910-dfabe586c1a5

Co-authored-by: danielbodnar <1790726+danielbodnar@users.noreply.github.com> Agent-Logs-Url: https://github.com/danielbodnar/dagger.nu/sessions/3240f946-4491-400e-9c07-4ea1ddf3a298

fix: portable mod.nu path in tests, recommend mod.nu in README

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-23T01:05:34Z

+
+# Top-level use — brings externs and helpers into parser scope so
+# scope commands reflects them and helper calls resolve without a subshell.
+use ../completions/dagger.nu *


use ../completions/dagger.nu * is a brittle relative path. When running the test as documented (nu tests/completions.test.nu from the repo root), this resolves to ../completions/... and can fail depending on how use resolves relative paths. Build the path from $env.FILE_PWD (like the mod.nu test does) so the suite works regardless of the current working directory.

Suggested change

use ../completions/dagger.nu *

use ($env.FILE_PWD | path join ".." "completions" "dagger.nu") *

danielbodnar added 2 commits February 28, 2026 12:24

danielbodnar marked this pull request as ready for review March 1, 2026 02:44

Copilot AI review requested due to automatic review settings March 1, 2026 02:44

Copilot started reviewing on behalf of danielbodnar March 1, 2026 02:44 View session

Copilot AI reviewed Mar 1, 2026

View reviewed changes

Initial plan

85f79bb

Copilot AI mentioned this pull request Mar 21, 2026

fix: portable mod.nu path in tests, recommend mod.nu in README #2

Merged

Copilot AI and others added 3 commits March 21, 2026 03:58

fix: dynamic mod.nu path in tests, recommend mod.nu in README

6c3dff3

Co-authored-by: danielbodnar <1790726+danielbodnar@users.noreply.github.com> Agent-Logs-Url: https://github.com/danielbodnar/dagger.nu/sessions/af9bae3d-4462-46d8-9910-dfabe586c1a5

fix(tests): rename mod-path to mod_path for snake_case consistency

5cba432

Co-authored-by: danielbodnar <1790726+danielbodnar@users.noreply.github.com> Agent-Logs-Url: https://github.com/danielbodnar/dagger.nu/sessions/3240f946-4491-400e-9c07-4ea1ddf3a298

Merge pull request #2 from danielbodnar/copilot/sub-pr-1

c9446f3

fix: portable mod.nu path in tests, recommend mod.nu in README

danielbodnar requested a review from Copilot March 23, 2026 01:02

Copilot started reviewing on behalf of danielbodnar March 23, 2026 01:02 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: subdirectory layout, mod.nu entry point, test suite#1

refactor: subdirectory layout, mod.nu entry point, test suite#1
danielbodnar wants to merge 6 commits intomainfrom
feat/restructure-and-tests

danielbodnar commented Feb 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 1, 2026

Uh oh!

Copilot AI Mar 1, 2026

Uh oh!

danielbodnar commented Mar 21, 2026

Uh oh!

Copilot AI commented Mar 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		let out = ^nu --no-config-file -c $"
		use '/workspaces/code/github.com/danielbodnar/dagger.nu/mod.nu' *

	use ../completions/dagger.nu *
	use ($env.FILE_PWD \| path join ".." "completions" "dagger.nu") *

Conversation

danielbodnar commented Feb 28, 2026

Summary

Test suite covers

Design note: export def for nu-complete helpers

Install path change

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

danielbodnar commented Mar 21, 2026

Uh oh!

Copilot AI commented Mar 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Design note: `export def` for `nu-complete` helpers