fix: portable mod.nu path in tests, recommend mod.nu in README#2
fix: portable mod.nu path in tests, recommend mod.nu in README#2danielbodnar merged 3 commits intofeat/restructure-and-testsfrom
Conversation
Co-authored-by: danielbodnar <1790726+danielbodnar@users.noreply.github.com> Agent-Logs-Url: https://github.com/danielbodnar/dagger.nu/sessions/af9bae3d-4462-46d8-9910-dfabe586c1a5
There was a problem hiding this comment.
Pull request overview
This PR fixes portability issues in the Nushell integration test by removing a hardcoded absolute module path, and updates the README to recommend the stable mod.nu entrypoint for manual installs.
Changes:
- Update
tests/completions.test.nuto compute the repositorymod.nupath dynamically from$env.FILE_PWD. - Update
README.mdto recommendmod.nuas the primary manual-install entry point (withcompletions/dagger.nuas an alternative).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/completions.test.nu | Removes hardcoded absolute path; builds mod.nu path dynamically for portability. |
| README.md | Documents mod.nu as the recommended entrypoint; keeps direct completions import as an alternative. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let mod-path = ([$env.FILE_PWD ".." "mod.nu"] | path join | path expand) | ||
| let out = ^nu --no-config-file -c $" | ||
| use '/workspaces/code/github.com/danielbodnar/dagger.nu/mod.nu' * | ||
| use '($mod-path)' * |
There was a problem hiding this comment.
The new variable name mod-path is inconsistent with the rest of this test file, which uses snake_case (e.g., all_tests). Consider renaming to mod_path (and updating the interpolation) for consistency and to avoid any potential parsing ambiguity around - in variable references.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: danielbodnar <1790726+danielbodnar@users.noreply.github.com> Agent-Logs-Url: https://github.com/danielbodnar/dagger.nu/sessions/3240f946-4491-400e-9c07-4ea1ddf3a298
Renamed |
Two issues from PR review: hardcoded absolute path in the
mod.nuintegration test broke on any non-workspace clone, and the README still pointed users at the completions file directly instead of the new stablemod.nuentrypoint.Changes
tests/completions.test.nu— computemod.nupath dynamically from$env.FILE_PWDinstead of embedding a hardcoded workspace path:README.md— promotemod.nuto the recommended manual install entry point; list the bare completions file as an alternative:✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.