fix(pulse): create ~/Library/LaunchAgents before writing launchd plist#1310
Open
stevetr68 wants to merge 1 commit into
Open
fix(pulse): create ~/Library/LaunchAgents before writing launchd plist#1310stevetr68 wants to merge 1 commit into
stevetr68 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PULSE/manage.sh installwrites the launchd plist to$HOME/Library/LaunchAgents/:…but the
install)case only createsstate/andlogs/:On a fresh macOS user account,
~/Library/LaunchAgents/does not exist until somethingcreates it. When it's missing, the
> "$PLIST_DST"redirect fails withNo such file or directory, the install aborts, and the user sees a confusingport 31337 did not binderror with no obvious cause.Fix
Add
"$HOME/Library/LaunchAgents"to the existingmkdir -p. One-line, idempotent,no behavior change on accounts where the directory already exists.
Hit this on a fresh-account PAI 5 install; this exact patch has been running locally
since. Related to the opaque-install-failure reports.