Skip to content

Add Python 3.14 to the CI test Matrix#1

Closed
dwskoog wants to merge 4 commits intodaq-tools:python314from
dwskoog:python314
Closed

Add Python 3.14 to the CI test Matrix#1
dwskoog wants to merge 4 commits intodaq-tools:python314from
dwskoog:python314

Conversation

@dwskoog
Copy link

@dwskoog dwskoog commented Dec 17, 2025

I merged streamz/master in and added a commit to include py314 in the test matrix.

@amotl
Copy link
Member

amotl commented Dec 17, 2025

Thank you. But wouldn't our repositories diverge, if we are cross-submitting GitHub PRs? Do you want me to merge this patch? Which option would you prefer? I am usually using rebase, or squash+rebase.

image

Because you have admin permissions on this repository when following the invite, feel free to merge at your disposal. Alternatively, I can just cherry-pick your commit into python-streamz#483 and close this PR again, so we will not get into bidirectional obstacles?

@dwskoog
Copy link
Author

dwskoog commented Dec 17, 2025

Thank you. But wouldn't our repositories diverge, if we are cross-submitting GitHub PRs? Do you want me to merge this patch? Which option would you prefer? I am usually using rebase, or squash+rebase.
Because you have admin permissions on this repository when following the invite, feel free to merge at your disposal. Alternatively, I can just cherry-pick your commit into python-streamz#483 and close this PR again, so we will not get into bidirectional obstacles?

I am avoiding opening a PR there to keep the python-streamz#483 discussion intact. However you want to pick this up is fine by me.

@dwskoog
Copy link
Author

dwskoog commented Dec 17, 2025

Closing this out since it's sorted now.

@dwskoog dwskoog closed this Dec 17, 2025
@amotl
Copy link
Member

amotl commented Dec 17, 2025

I think it's better keep the flow linear re. upstream vs. downstream vs. fork modes, instead of introducing a bidirectional flow between fork and upstream, or fork <-> fork.

Did you know you can reference commits from all forks in discussions, they don't even need PRs to become visible to the whole network on GitHub. In this spirit, it's also easy to run a miniature collaborative workflow like:

Hey, I've staged an improvement to your patch. Feel free to cherry-pick 930c8be at your disposal.

@amotl
Copy link
Member

amotl commented Dec 17, 2025

Closing this out since it's sorted now.

Thank you so much for saving a few keystrokes on my end by completing python-streamz#483 excellently. I hope Martin will be happy about it. 🍀

@dwskoog dwskoog deleted the python314 branch December 17, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants