refactor: deduplicate cross-platform stat and JSON parsing patterns#9
Open
artifex-bot[bot] wants to merge 1 commit intomainfrom
Open
refactor: deduplicate cross-platform stat and JSON parsing patterns#9artifex-bot[bot] wants to merge 1 commit intomainfrom
artifex-bot[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
get_file_mtime(),get_file_size(), andget_file_mtime_human()helpers tolib/platform.shto centralize cross-platform stat commandshandoff.sh,session-start.sh, andcheckpoint.shto use the shared helpers instead of inline stat fallback chainslib/hook-config.shby combining the type-check and value-extraction into a single jq call per config filetldr-stats.shandtrack-tldr.shwith a sharedjson_num()helpercompile-skills.shto a single conditional patternWhy
The codebase had the same cross-platform
statfallback pattern (stat -f%m ... || stat -c%Y ... || echo 0) duplicated across 5+ scripts. Similarly,get_hook_config()was making 2 jq calls per config file (type check + value extraction) when 1 suffices. These are low-effort, high-impact maintainability wins that reduce code duplication and improve consistency.