-
Notifications
You must be signed in to change notification settings - Fork 121
Added a warning for non exportable types in export-dir
#4101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrewnester
merged 4 commits into
databricks:main
from
varundeepsaini:fix/export-dir-experiments
Dec 23, 2025
Merged
Added a warning for non exportable types in export-dir
#4101
andrewnester
merged 4 commits into
databricks:main
from
varundeepsaini:fix/export-dir-experiments
Dec 23, 2025
+72
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@andrewnester bump ^^ |
andrewnester
requested changes
Dec 22, 2025
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Collaborator
|
Commit: 7147e1d
32 interesting tests: 14 KNOWN, 7 FAIL, 6 RECOVERED, 4 BUG, 1 SKIP
Top 48 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Dec 23, 2025
Collaborator
|
Commit: fe1b364
27 interesting tests: 14 KNOWN, 6 RECOVERED, 4 BUG, 2 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4081
Changes
Skip non-exportable workspace objects (like
MLFLOW_EXPERIMENT) duringworkspace export-dirinstead of failing the entire export. Warnings are collected and displayed at the end.Why
Currently,
export-dirfails when a directory contains an MLflow experiment because experiments cannot be exported via the workspace export API. This makes it impossible to export any folder containing an experiment.This change skips non-exportable object types (
LIBRARY,DASHBOARD,REPO,MLFLOW_EXPERIMENT) and shows warnings at the end:Note: Ideally,
ObjectTypeMlflowExperimentshould be added todatabricks-sdk-goas a constant. Currently using a string literal as a workaround.Tests
cmd/workspace/export-dir-skip-experimentscmd/workspace/export-dir-file-size-limitoutput format