-
Notifications
You must be signed in to change notification settings - Fork 121
Added a warning for non exportable types in export-dir
#4101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrewnester
merged 4 commits into
databricks:main
from
varundeepsaini:fix/export-dir-experiments
Dec 23, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cb93677
Added a warning for non exportable types
varundeepsaini 71416e4
updated the logs to be inline and removed storing the warnings
varundeepsaini 937fe6c
Merge branch 'main' into fix/export-dir-experiments
varundeepsaini 7147e1d
updated the changelog
varundeepsaini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 1 addition & 5 deletions
6
acceptance/cmd/workspace/export-dir-file-size-limit/output.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,5 @@ | ||
|
|
||
| >>> [CLI] workspace export-dir /test-dir [TEST_TMP_DIR]/export | ||
| Exporting files from /test-dir | ||
| Warning: /test-dir/file.py (skipped; file too large) | ||
|
|
||
| The following files were skipped because they exceed the maximum size limit: | ||
| - /test-dir/file.py (skipped; file too large) | ||
|
|
||
| /test-dir/file.py (skipped; file too large) | ||
| Export complete | ||
5 changes: 5 additions & 0 deletions
5
acceptance/cmd/workspace/export-dir-skip-experiments/out.test.toml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
5 changes: 5 additions & 0 deletions
5
acceptance/cmd/workspace/export-dir-skip-experiments/output.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
|
|
||
| >>> [CLI] workspace export-dir /test-dir [TEST_TMP_DIR]/export | ||
| Exporting files from /test-dir | ||
| /test-dir/experiment (skipped; cannot export MLFLOW_EXPERIMENT) | ||
| Export complete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| mkdir -p "$TEST_TMP_DIR/export" | ||
| trace $CLI workspace export-dir /test-dir "$TEST_TMP_DIR/export" |
29 changes: 29 additions & 0 deletions
29
acceptance/cmd/workspace/export-dir-skip-experiments/test.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| Local = true | ||
| Cloud = false | ||
|
|
||
| [Env] | ||
| MSYS_NO_PATHCONV = "1" | ||
|
|
||
| [[Server]] | ||
| Pattern = "GET /api/2.0/workspace/list" | ||
| Response.Body = ''' | ||
| { | ||
| "objects": [ | ||
| { | ||
| "path": "/test-dir/experiment", | ||
| "object_type": "MLFLOW_EXPERIMENT", | ||
| "object_id": 125 | ||
| } | ||
| ] | ||
| } | ||
| ''' | ||
|
|
||
| [[Server]] | ||
| Pattern = "GET /api/2.0/workspace/get-status" | ||
| Response.Body = ''' | ||
| { | ||
| "path": "/test-dir", | ||
| "object_type": "DIRECTORY", | ||
| "object_id": 123 | ||
| } | ||
| ''' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.