Skip to content

Don't expire notifications when the timeout expires#211

Merged
danirabbit merged 7 commits intomasterfrom
fix-expiring
Aug 21, 2023
Merged

Don't expire notifications when the timeout expires#211
danirabbit merged 7 commits intomasterfrom
fix-expiring

Conversation

@leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jul 20, 2023

We only close the window but don't send the notification_closed signal. That's because they are still visible in the notifications indicator and can still receive input/responses especially with elementary/panel-notifications#263.

Fixes #104
Closes #212

@leolost2605 leolost2605 requested a review from a team July 20, 2023 13:51
@Marukesu
Copy link
Contributor

i would like to restore the expiration feature in the future, so a simpler way to remove the expiration now is to remove src/DBus.vala:156.

@leolost2605
Copy link
Member Author

leolost2605 commented Jul 22, 2023

But wouldn't that also prevent the signal from clicking the close button from being emitted?

@Marukesu
Copy link
Contributor

take a more thought look at this, i believe the right way to go here is something along this lines:

   bubble[id].closed.connect ((res) => {
       if (res is EXPIRED && app_settings.get_boolean ("remember")) {
           return;
       }

       notification_closed (id, res);
   });

that will make sure that we keep expiring the notifications that shouldn't go to the tray.

@leolost2605
Copy link
Member Author

@Marukesu nice, I updated it accordingly!

Marukesu
Marukesu previously approved these changes Jul 28, 2023
Copy link
Contributor

@Marukesu Marukesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry the delay in the review. works as expected.

@leolost2605

This comment was marked as resolved.

@leolost2605 leolost2605 marked this pull request as ready for review July 28, 2023 22:01
@danirabbit

This comment was marked as resolved.

@danirabbit danirabbit mentioned this pull request Aug 18, 2023
@leolost2605

This comment was marked as resolved.

@danirabbit
Copy link
Member

@Marukesu Do you still approve here? :)

@danirabbit danirabbit merged commit 3ff171b into master Aug 21, 2023
@danirabbit danirabbit deleted the fix-expiring branch August 21, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invisible notification blocking input Notifications are closed automatically with reason expired

3 participants