Bugfix: Fix emrun --browser=open option for macOS #26313
Open
benjiwolff wants to merge 1 commit intoemscripten-core:mainfrom
Open
Bugfix: Fix emrun --browser=open option for macOS #26313benjiwolff wants to merge 1 commit intoemscripten-core:mainfrom
benjiwolff wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
changed the title
benjiwolff
changed the title
Collaborator
|
Certainly seems worth fixing Perhaps @brendandahl (or someone who actually uses macOS) would know the best was to proceed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #8179 it was decided, that on macOS, the default browser for
emrunshould be the system browser. And so it was implemented in #8243.However, when fixing a seemingly unrelated Safari bug in #12034, the system browser option "open" was effectively removed. It since has the same effect, as choosing Safari.
I don't have a preference, whether the system browser or Safari should be the default. But when I explicitly choose
--browser=open, I want my system browser.Side note: Using Safari over brave for example, does not seem to improve my experience in any way. Both are equally detached, as they are launched with
openand neither terminating the browser nor the emrun process stops the other.