Skip to content

Bugfix: Fix emrun --browser=open option for macOS #26313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benjiwolff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bugfix: Fix emrun --browser=open option for macOS #26313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion emrun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,7 +1739,7 @@ def run(args): # noqa: C901, PLR0912, PLR0915
browser_exe = browser[0]
browser_args = shlex.split(unwrap(options.browser_args))

if MACOS and ('safari' in browser_exe.lower() or browser_exe == 'open'):
if MACOS and 'safari' in browser_exe.lower():
# Safari has a bug that a command line 'Safari http://page.com' does
# not launch that page, but instead launches 'file:///http://page.com'.
# To remedy this, must use the open -a command to run Safari, but
Expand Down