refactor: drop poll_for_swap_creation, reuse poll_for_swap_with_progress in post-tx#138
Open
dataCenter430 wants to merge 1 commit intoentrius:testfrom
Open
Conversation
3cf3d9a to
7a8d8de
Compare
7a8d8de to
64689aa
Compare
Author
|
Hi, @LandynDev |
0e6f8c7 to
5715d4c
Compare
Author
|
Hi, @LandynDev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #137
Summary
poll_for_swap_creationinswap.pywas a duplicate ofpoll_for_swap_with_progress— identical polling logic, but with a static spinner and no elapsed-time feedback.It had a single call site in
post_tx.py.Changes:
messageparameter topoll_for_swap_with_progress(default keeps existing callers unchanged)poll_for_swap_creationcall inpost_tx.pywithpoll_for_swap_with_progress,passing
message='Waiting for swap to appear on-chain...'to preserve the original UX textpoll_for_swap_creationfromswap.pyVisual diff (
alw swap post-txfinal polling step)Before:
(static — no time feedback)
After:
(same message, now with live elapsed time, keep clean and concise code, remove unnecessary duplication)