watch-dog: fix worker-thread watch-dog threads using main-thread config#43522
Open
adisuissa wants to merge 7 commits intoenvoyproxy:mainfrom
Open
watch-dog: fix worker-thread watch-dog threads using main-thread config#43522adisuissa wants to merge 7 commits intoenvoyproxy:mainfrom
adisuissa wants to merge 7 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
…read_fix Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
…read_fix Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
adisuissa
requested review from
RyanTheOptimist,
abeyad and
danzh2010
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: watch-dog: fix worker-thread watch-dog threads using main-thread config
Additional Description:
In PR #30896 the watchdog instantiation was refactored, and a bug was introduced where both the main thread's and the worker threads' watch-dogs are configured using the main-thread's config.
This PR fixes the issue by passing the correct configuration.
Risk Level: Medium - may change the behavior of systems where worker-threads' watch-dogs will trigger.
Testing: Added unit and integration tests.
Docs Changes: N/A
Release Notes: Added.
Platform Specific Features: N/A
Runtime guard: Added
envoy.restart_features.worker_threads_watchdog_fixthat can temporarily disable the fix.