Migrate sh_binary/sh_test loads for Bazel 9 compatibility#66
Open
jinfwhuang wants to merge 1 commit intofasterci:mainfrom
Open
Migrate sh_binary/sh_test loads for Bazel 9 compatibility#66jinfwhuang wants to merge 1 commit intofasterci:mainfrom
jinfwhuang wants to merge 1 commit intofasterci:mainfrom
Conversation
Bazel 9 removes the native sh_binary, sh_test, and sh_library rules; they must be loaded from @rules_shell. Add rules_shell as a module dependency and add the corresponding load() statements to every BUILD file (and the generated BUILD in the kustomize repository rule) that uses them.
jinfwhuang
force-pushed
the
jin/bazel9-sh-rules
branch
from
4d9b14f to
cf06976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel 9 removes the native
sh_binary,sh_test, andsh_libraryrules; they must be loaded from@rules_shell(Bazel 9 release notes).PR #65 already removed
incompatible_use_toolchain_transitionfor Bazel 9, but thesh_*usages were still relying on the native (now-removed) rules. Without these load statements, consumers on Bazel 9 hit:This change improves Bazel 9 compatibility for shell rules.