Skip to content

Migrate sh_binary/sh_test loads for Bazel 9 compatibility #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jinfwhuang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Migrate sh_binary/sh_test loads for Bazel 9 compatibility #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ bazel_dep(name = "platforms", version = "0.0.11")
bazel_dep(name = "rules_oci", version = "2.2.6")
bazel_dep(name = "rules_pkg", version = "1.0.1")
bazel_dep(name = "rules_go", version = "0.54.0")
bazel_dep(name = "rules_shell", version = "0.8.0")

go_sdk = use_extension("@rules_go//go:extensions.bzl", "go_sdk")
go_sdk.download(version = "1.23.9")
Expand Down
5 changes: 3 additions & 2 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions mirror/tests/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
load("@rules_gitops//gitops:defs.bzl", "k8s_deploy", "k8s_test_setup")
load("@rules_gitops//skylib/kustomize:kustomize.bzl", "kustomize")
load("@rules_oci//oci:defs.bzl", "oci_image", "oci_push")
load("@rules_shell//shell:sh_test.bzl", "sh_test")
load("//mirror:defs.bzl", "mirror_image")

# create a simple image for testing
Expand Down
2 changes: 2 additions & 0 deletions skylib/kustomize/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
# OF ANY KIND, either express or implied. See the License for the specific language
# governing permissions and limitations under the License.

load("@rules_shell//shell:sh_binary.bzl", "sh_binary")

exports_files([
"run-all.sh.tpl",
"kubectl.sh.tpl",
Expand Down
1 change: 1 addition & 0 deletions skylib/kustomize/kustomize.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def _download_kustomize_impl(ctx):
fail("Platform " + ctx.os.name + " is not supported")

ctx.file("BUILD", """
load("@rules_shell//shell:sh_binary.bzl", "sh_binary")
sh_binary(
name = "kustomize",
srcs = ["bin/kustomize"],
Expand Down
1 change: 1 addition & 0 deletions skylib/kustomize/tests/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ load("@aspect_bazel_lib//lib:tar.bzl", "tar")
load("@aspect_bazel_lib//lib:write_source_files.bzl", "write_source_files")
load("@bazel_tools//tools/build_rules:test_rules.bzl", "file_test")
load("@rules_oci//oci:defs.bzl", "oci_image")
load("@rules_shell//shell:sh_test.bzl", "sh_test")
load("//push_oci:push_oci.bzl", "push_oci_rule")
load("//skylib:push_alias.bzl", "pushed_image_alias")
load("//skylib/kustomize:kustomize.bzl", "gitops", "kubectl", "kustomize", "push_all")
Expand Down
1 change: 1 addition & 0 deletions skylib/tests/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
# OF ANY KIND, either express or implied. See the License for the specific language
# governing permissions and limitations under the License.

load("@rules_shell//shell:sh_test.bzl", "sh_test")
load("//skylib:k8s.bzl", "k8s_deploy")

k8s_deploy(
Expand Down
1 change: 1 addition & 0 deletions transitions/tests/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
load("@aspect_bazel_lib//lib:diff_test.bzl", "diff_test")
load("@bazel_skylib//rules:write_file.bzl", "write_file")
load("@rules_go//go:def.bzl", "go_binary", "go_library")
load("@rules_shell//shell:sh_test.bzl", "sh_test")
load("//transitions:transitions.bzl", "platform_transition_binary", "platform_transition_filegroup")

platform(
Expand Down