Open
Conversation
climba03003
reviewed
Mar 2, 2026
Member
climba03003
left a comment
climba03003
left a comment
There was a problem hiding this comment.
Using const { test: nodeTest } = require('node:test') and keep the test() in all files
More consistence usage and easier to migrate if we plan to use another test framework.
test/graceful-shutdown.test.js
Outdated
|
|
||
| const t = require('tap') | ||
| const { once } = require('node:events') | ||
| const { test, beforeEach, afterEach } = require('node:test') |
Member
There was a problem hiding this comment.
Suggested change
| const { test, beforeEach, afterEach } = require('node:test') | |
| const { test: nodeTest, beforeEach, afterEach } = require('node:test') |
test/graceful-shutdown.test.js
Outdated
| const assert = require('node:assert/strict') | ||
| // Tests skip on win32 platforms due SIGINT signal is not supported across all windows platforms | ||
| const test = (process.platform === 'win32') ? t.skip : t.test | ||
| const testFn = (process.platform === 'win32') ? (name, fn) => test(name, { skip: true }, fn) : test |
Member
There was a problem hiding this comment.
Suggested change
| const testFn = (process.platform === 'win32') ? (name, fn) => test(name, { skip: true }, fn) : test | |
| const test = (process.platform === 'win32') ? (name, fn) => test(name, { skip: true }, fn) : test |
test/graceful-shutdown.test.js
Outdated
| t.plan(2) | ||
|
|
||
| t.equal(process.listenerCount('SIGINT'), signalCounter + 1) | ||
| testFn('should add and remove SIGINT listener as expected ', async () => { |
Member
There was a problem hiding this comment.
Suggested change
| testFn('should add and remove SIGINT listener as expected ', async () => { | |
| test('should add and remove SIGINT listener as expected ', async () => { |
test/graceful-shutdown.test.js
Outdated
| sinon.assert.called(spy) | ||
|
|
||
| t.end() | ||
| testFn('should have called fastify.close() when receives a SIGINT signal', async (t) => { |
Member
There was a problem hiding this comment.
Suggested change
| testFn('should have called fastify.close() when receives a SIGINT signal', async (t) => { | |
| test('should have called fastify.close() when receives a SIGINT signal', async (t) => { |
This was referenced Mar 2, 2026
Member
Author
|
Addressed review feedback:
Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node:testtest/start.test.jsvia a local compat wrappertest/graceful-shutdown.test.jstonode:testexamples/plugin-with-preloaded.jssuite-runner.jstapand@types/tapfromdevDependenciesValidation
node --test test/start.test.jsnode --test test/graceful-shutdown.test.js