Open
Conversation
### Description The test:functions-discover test was failing on Node 20 because the latest pnpm requires Node 22+ (due to node:sqlite). This PR updates the CI workflow to run this specific test on Node 24 instead. ### Scenarios Tested - Verified that the workflow file syntax is correct. - Verified that run.sh is restored to use the latest pnpm. ### Sample Commands npm run test:functions-discover
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
ajperel
approved these changes
May 7, 2026
### Description Newer versions of pnpm require explicit approval for build scripts. This PR adds onlyBuiltDependencies to the pnpm fixture's package.json to allow @firebase/util and protobufjs to run their build scripts. ### Scenarios Tested - Verified that the fixture package.json was updated.
### Description Adding onlyBuiltDependencies to package.json didn't resolve the ERR_PNPM_IGNORED_BUILDS error in CI. This PR switches to using pnpm install --ignore-scripts in the fixture's install script to bypass the issue entirely, as the test likely does not need the build scripts to run. ### Scenarios Tested - Verified that the fixture install.sh was updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test:functions-discover test was failing on Node 20 because the latest pnpm requires Node 22+ (due to node:sqlite). This PR updates the CI workflow to run this specific test on Node 24 instead.
Scenarios Tested
Sample Commands
npm run test:functions-discover