Skip to content

test: run functions-discover test on Node 24 #10474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joehan wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −3
Open

test: run functions-discover test on Node 24 #10474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3b59b1
test: run functions-discover test on Node 24
joehan May 7, 2026
15f3866
test: allow built dependencies in pnpm fixture
joehan May 7, 2026
bfd08cb
test: ignore scripts in pnpm fixture install
joehan May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/node-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ jobs:
- npm run test:emulator
- npm run test:extensions-emulator
- npm run test:frameworks
- npm run test:functions-discover
- npm run test:hosting
# - npm run test:hosting-rewrites # Long-running test that might conflict across test runs. Run this manually.
- npm run test:import-export
Expand All @@ -217,6 +216,9 @@ jobs:
- npm run test:triggers-end-to-end:inspect
# - npm run test:dataconnect-deploy
- npm run test:dataconnect-emulator
include:
- node-version: "24"
script: "npm run test:functions-discover"
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
Expand Down Expand Up @@ -276,14 +278,16 @@ jobs:
- npm run test:emulator
# - npm run test:import-export # Fails becuase port 4000 is taken after first run - hub not shutting down?
# - npm run test:extensions-emulator # Fails due to cannot find module sharp (not waiting for npm install?)
- npm run test:functions-discover
# - npm run test:triggers-end-to-end
- npm run test:triggers-end-to-end:inspect
- npm run test:storage-deploy
# - npm run test:storage-emulator-integration
# - npm run test:dataconnect-deploy # TODO (joehanley): Reenable this - it should be safe to run in parallel
# - npm run test:dataconnect-emulator # TODO (joehanley): Figure out why this is failing
# - npm run test:frameworks
include:
- node-version: "24"
script: "npm run test:functions-discover"
steps:
- name: Setup Java JDK
uses: actions/setup-java@v3.3.0
Expand Down
6 changes: 6 additions & 0 deletions scripts/functions-discover-tests/fixtures/pnpm/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,11 @@
"name": "pnpm",
"dependencies": {
"firebase-functions": "^6.4.0"
},
"pnpm": {
"onlyBuiltDependencies": [
"@firebase/util",
"protobufjs"
]
}
}
2 changes: 1 addition & 1 deletion scripts/functions-discover-tests/fixtures/pnpm/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
set -euxo pipefail # bash strict mode
IFS=$'\n\t'

cd functions && pnpm install
cd functions && pnpm install --ignore-scripts
Loading