refactor: Fix incorrect open-checksum in RPM repomd.xml#15
Merged
Conversation
The open-checksum was incorrectly computed as the SHA256 of the checksum string itself rather than the uncompressed primary.xml content. RPM clients (dnf/yum) expect the open-checksum to match the uncompressed data for integrity verification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bketelsen
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
internal/generator/rpm/generator.go:353, theopen-checksumfield inrepomd.xmlis computed incorrectly. It callsutils.CalculateChecksum([]byte(primaryChecksum), "sha256"), which computes the SHA256 of the checksum string itself rather than of the uncompressedprimaryXMLdata. Theopen-checksumshould be the SHA256 of the uncompressed primary.xml content, which is what RPM clients (dnf/yum) expect for integrity verification.Fix: Pass the uncompressed
primaryXMLbytes intogenerateRepomdXML()and compute the open-checksum from that data. In the caller at line 159, change the signature to also acceptprimaryXML []byte, and at line 353, change toutils.CalculateChecksum(primaryXML, "sha256").Automated improvement by yeti improvement-identifier