Skip to content

refactor: Fix incorrect open-checksum in RPM repomd.xml #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bketelsen merged 1 commit into from
Mar 27, 2026
Merged

refactor: Fix incorrect open-checksum in RPM repomd.xml #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/generator/rpm/generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func (g *Generator) generateForVersionArch(ctx context.Context, config *models.R
}

// Generate repomd.xml
repomdXML, err := generateRepomdXML(primaryChecksum, int64(len(primaryGz)), int64(len(primaryXML)))
repomdXML, err := generateRepomdXML(primaryChecksum, primaryXML, int64(len(primaryGz)))
if err != nil {
return fmt.Errorf("failed to generate repomd.xml: %w", err)
}
Expand Down Expand Up @@ -349,8 +349,8 @@ type repomdLocation struct {
Href string `xml:"href,attr"`
}

func generateRepomdXML(primaryChecksum string, compressedSize, uncompressedSize int64) ([]byte, error) {
openChecksum, _ := utils.CalculateChecksum([]byte(primaryChecksum), "sha256")
func generateRepomdXML(primaryChecksum string, primaryXML []byte, compressedSize int64) ([]byte, error) {
openChecksum, _ := utils.CalculateChecksum(primaryXML, "sha256")

repomd := repomd{
Xmlns: "http://linux.duke.edu/metadata/repo",
Expand All @@ -372,7 +372,7 @@ func generateRepomdXML(primaryChecksum string, compressedSize, uncompressedSize
},
Timestamp: time.Now().Unix(),
Size: compressedSize,
OpenSize: uncompressedSize,
OpenSize: int64(len(primaryXML)),
},
},
}
Expand Down
Loading