Skip to content

chore(deps): update WORKFLOW-TEST-DEPENDENCY-DO-NOT-MERGE to v2.0.4#66

Open
github-actions[bot] wants to merge 1 commit intomainfrom
deps/updater/tests/sentry-cli.properties
Open

chore(deps): update WORKFLOW-TEST-DEPENDENCY-DO-NOT-MERGE to v2.0.4#66
github-actions[bot] wants to merge 1 commit intomainfrom
deps/updater/tests/sentry-cli.properties

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Dec 7, 2023

Bumps updater/tests/sentry-cli.properties from 2.0.0 to 2.0.4.

Auto-generated by a dependency updater.

Changelog

2.0.4

Various fixes & improvements

  • ref: Prevent vercel/nft and similar tools from including binary file in their bundles (#1207) by kamilogorek
  • ref: Use node-fetchv2 for the simplicity sake (#1206) by kamilogorek

2.0.3

Various fixes & improvements

  • ref: Make --header a global flag so its position independent (#1194)
  • ref: Restore monitors as hidden command w. integration tests (#1196)
  • ref: Restore bash-hook as hidden command w. integration tests (#1197)

2.0.2

Various fixes & improvements

  • fix: Remove fetch.FetchError usage in favor of catch-all clause (#1193) by kamilogorek
  • ref: Restore and hide legacy aliases from 1.x for backward compatibility (#1192) by kamilogorek

2.0.1

Various fixes & improvements

  • fix: Allow hyphenated release names with any flags position (#1187) by kamilogorek

  • ref: Hide difutil id subcommand (use debug-files check instead)

  • ref: Hide upload-dsym command (use debug-files upload instead)

  • ref: Make releases upload-sourcemaps --rewrite a default behavior now

  • ref: Remove upload-dsym command (use debug-files upload instead) (breaking) restored in 2.0.2 as hidden alias

  • ref: Remove difutil id subcommand (use debug-files check instead) (breaking) restored in 2.0.2 as hidden alias

  • ref: Remove monitors command (support for this feature has been dropped) (breaking) - restored in 2.0.3 as hidden command

  • ref: Remove bash-hook command (use 1.x if you still need the functionality) (breaking) - restored in 2.0.3 as hidden command

  • ref: Make ignore-empty for releases set-commits a default behavior and hide --ignore-empty flag (remove --ignore-empty usage) (breaking)

Full CHANGELOG.md diff
 -2,6 +2,34 
 
 "You know what they say. Fool me once, strike one, but fool me twice... strike three." — Michael Scott
 
+## 2.0.4
+
+### Various fixes & improvements
+
+- ref: Prevent vercel/nft and similar tools from including binary file in their bundles ([#1207](https://github-redirect.dependabot.com/getsentry/sentry-cli/issues/1207)) by kamilogorek
+- ref: Use node-fetchv2 for the simplicity sake ([#1206](https://github-redirect.dependabot.com/getsentry/sentry-cli/issues/1206)) by kamilogorek
+
+## 2.0.3
+
+### Various fixes & improvements
+
+- ref: Make `--header` a global flag so its position independent ([#1194](https://github-redirect.dependabot.com/getsentry/sentry-cli/issues/1194))
+- ref: Restore `monitors` as hidden command w. integration tests ([#1196](https://github-redirect.dependabot.com/getsentry/sentry-cli/issues/1196))
+- ref: Restore `bash-hook` as hidden command w. integration tests ([#1197](https://github-redirect.dependabot.com/getsentry/sentry-cli/issues/1197))
+
+## 2.0.2
+
+### Various fixes & improvements
+
+- fix: Remove `fetch.FetchError` usage in favor of catch-all clause ([#1193](https://github-redirect.dependabot.com/getsentry/sentry-cli/issues/1193)) by kamilogorek
+- ref: Restore and hide legacy aliases from 1.x for backward compatibility ([#1192](https://github-redirect.dependabot.com/getsentry/sentry-cli/issues/1192)) by kamilogorek
+
+## 2.0.1
+
+### Various fixes & improvements
+
+- fix: Allow hyphenated release names with any flags position ([#1187](https://github-redirect.dependabot.com/getsentry/sentry-cli/issues/1187)) by kamilogorek
+
 ## 2.0.0
 
 This is the first, long-overdue major release in over 5 years of sentry-cli's life.
 -24,28 +52,24  Breaking changes are denotated with _(breaking)_ tag, and appropriate required c
 
 ### Removed APIs
 
-- ref: Remove `difutil id` subcommand (use `debug-files check` instead) _(breaking)_
-- ref: Remove `monitors` command (support for this feature has been dropped) _(breaking)_
 - ref: Remove `react-native codepush` subcommand (use `react-native appcenter` instead) _(breaking)_
 - ref: Remove `react-native-gradle` and `react-native-xcode` commands (use `react-native gradle` and `react-native xcode` instead) _(breaking)_
-- ref: Remove `upload-dsym` command (use `debug-files upload` instead) _(breaking)_
-- ref: Remove deprecated and hidden flags from commands (remove listed flags usage) _(breaking)_
-  - `react-native xcode --verbose`
-  - `releases new --ref`
-  - `releases list --no-abbrev`
-  - `releases upload-sourcemaps --verbose`
-  - `releases upload-sourcemaps --rewrite` (it's a default behavior now)
-  - `upload-dif --upload-symbol-maps`
-- ref: Remove `bash-hook` command (use `1.x` if you still need the functionality; it will eventually be ported as a separate repository - https://github.com/getsentry/sentry-cli-bash-hook) _(breaking)_
 - ref: Remove `crash_reporting` related code and `with_crash_reporting` crate feature (no required changes) _(breaking)_
 - ref: Remove `SENTRY_NO_PROGRESS_BAR` env var in favor of `SENTRYCLI_NO_PROGRESS_BAR` (rename env variable) _(breaking)_
+- ref: Hide `difutil id` subcommand (use `debug-files check` instead)
+- ref: Hide `upload-dsym` command (use `debug-files upload` instead)
+- ref: Make `releases upload-sourcemaps --rewrite` a default behavior now
+- ~ref: Remove `upload-dsym` command (use `debug-files upload` instead) _(breaking)_~ _restored in 2.0.2 as hidden alias_
+- ~ref: Remove `difutil id` subcommand (use `debug-files check` instead) _(breaking)_~ _restored in 2.0.2 as hidden alias_
+- ~ref: Remove `monitors` command (support for this feature has been dropped) _(breaking)_~ - _restored in 2.0.3 as hidden command_
+- ~ref: Remove `bash-hook` command (use `1.x` if you still need the functionality) _(breaking)_~ - _restored in 2.0.3 as hidden command_
 
 ### Breaking Changes
 
 - ref: Update minimal required `node` version to `v12` (update node version) _(breaking)_
 - ref: Rename `--header` argument of `releases files upload` command to `--file-header` (rename flag) _(breaking)_
 - ref: Rename `CUSTOM_HEADER` to `SENTRY_HEADER` and `defaults.custom_header` to `http.header` (rename env variable or update config file) _(breaking)_
-- ref: Make `ignore-empty` for `releases set-commits` a default behavior and remove `--ignore-empty` flag (remove `--ignore-empty` usage) _(breaking)_
+- ref: Make `ignore-empty` for `releases set-commits` a default behavior and hide `--ignore-empty` flag (remove `--ignore-empty` usage) _(breaking)_
 
 ### Various fixes & improvements
 

@github-actions github-actions Bot force-pushed the deps/updater/tests/sentry-cli.properties branch 7 times, most recently from 17920c9 to 243e8ae Compare December 7, 2023 17:27
@github-actions github-actions Bot changed the title chore(deps): update CLI to v2.0.4 chore(deps): update WORKFLOW-TEST-DEPENDENCY-DO-NOT-MERGE to v2.0.4 Dec 7, 2023
vaind

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge this please, this is part of test CI: .github\workflows\workflow-tests.yml

@github-actions github-actions Bot force-pushed the deps/updater/tests/sentry-cli.properties branch 3 times, most recently from ebb58d6 to df7f1ea Compare January 25, 2024 15:50
@github-actions github-actions Bot force-pushed the deps/updater/tests/sentry-cli.properties branch 3 times, most recently from d4da8f6 to 1e3ad4f Compare February 11, 2024 12:40
@github-actions github-actions Bot force-pushed the deps/updater/tests/sentry-cli.properties branch 13 times, most recently from aa4caac to 6a5e55a Compare March 5, 2024 08:15
@github-actions github-actions Bot force-pushed the deps/updater/tests/sentry-cli.properties branch 18 times, most recently from 4bae836 to d68253e Compare September 22, 2025 07:26
vaind

This comment was marked as duplicate.

@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
repo = https://github.com/getsentry/sentry-cli

This comment was marked as outdated.

@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
repo = https://github.com/getsentry/sentry-cli
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The workflow tests have a hardcoded version check for 2.0.0, but the properties file is being updated to 2.0.4. This will cause the CI pipeline to fail.
Severity: HIGH

Suggested Fix

Update the hardcoded version string in the assertions within .github/workflows/workflow-tests.yml from 2.0.0 to 2.0.4 to match the change in the sentry-cli.properties file.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The version in `updater/tests/sentry-cli.properties` was updated from
`2.0.0` to `2.0.4`. The updater script reads this version and sets it as the
`ORIGINAL_TAG` output. However, the CI workflow tests in
`.github/workflows/workflow-tests.yml` contain hardcoded assertions that check if the
`ORIGINAL_TAG` is `2.0.0`. After this change, the `ORIGINAL_TAG` will be `2.0.4`,
causing the test assertions to fail because the value does not match the expected
`2.0.0`. This will cause the CI pipeline to fail when the pull request is merged.

Did we get this right? 👍 / 👎 to inform future reviews.

@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
repo = https://github.com/getsentry/sentry-cli
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The version in sentry-cli.properties was updated to 2.0.4, but the corresponding hardcoded assertions in the workflow tests still expect 2.0.0, which will cause CI failures.
Severity: MEDIUM

Suggested Fix

Update the hardcoded version string in the assertions within .github/workflows/workflow-tests.yml from "2.0.0" to "2.0.4" to match the change in updater/tests/sentry-cli.properties.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The PR updates the version in `updater/tests/sentry-cli.properties` to
`2.0.4`, but the CI workflow tests in `.github/workflows/workflow-tests.yml` contain
hardcoded assertions that expect the original version to be `2.0.0`. When the workflow
runs, it will read the new version `2.0.4` and set the `originalTag` output to this
value. This will cause the test assertion `$env:ORIGINAL_TAG | Should -Be "2.0.0"` to
fail in both the `updater-pr-creation` and `updater-target-branch` jobs, breaking the CI
pipeline.

@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
repo = https://github.com/getsentry/sentry-cli
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The CI workflow has a hardcoded assertion expecting version "2.0.0", but this PR updates the test dependency to "2.0.4", which will cause the test to fail.
Severity: MEDIUM

Suggested Fix

Update the hardcoded assertions in .github/workflows/workflow-tests.yml to expect the new version "2.0.4". Specifically, change the lines $env:ORIGINAL_TAG | Should -Be "2.0.0" to $env:ORIGINAL_TAG | Should -Be "2.0.4".

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The pull request updates the version in the test dependency file
`updater/tests/sentry-cli.properties` from `2.0.0` to `2.0.4`. However, the CI workflow
in `.github/workflows/workflow-tests.yml` contains hardcoded assertions that expect the
`originalTag` output to be `"2.0.0"`. After this PR is merged, the updater action will
read `2.0.4` as the original version, causing the assertion `$env:ORIGINAL_TAG | Should
-Be "2.0.0"` to fail. This will result in a CI failure on subsequent workflow runs
triggered after the merge.

@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
repo = https://github.com/getsentry/sentry-cli
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The version in updater/tests/sentry-cli.properties was updated, but the corresponding hardcoded version 2.0.0 in the CI test assertions in .github/workflows/workflow-tests.yml was not.
Severity: HIGH

Suggested Fix

Update the hardcoded version assertions in the updater-pr-creation and updater-target-branch test jobs within .github/workflows/workflow-tests.yml from "2.0.0" to "2.0.4" to match the new version in updater/tests/sentry-cli.properties.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The version in `updater/tests/sentry-cli.properties` was updated from
`2.0.0` to `2.0.4`, but the CI test assertions in `.github/workflows/workflow-tests.yml`
were not updated. The tests contain hardcoded assertions that check if the `originalTag`
is `2.0.0`. After this change is merged, the updater action will read `2.0.4` from the
properties file, causing the `originalTag` output to be `"2.0.4"`. Consequently, the
test assertion `$env:ORIGINAL_TAG | Should -Be "2.0.0"` will fail, breaking the
`updater-pr-creation` and `updater-target-branch` test jobs on every subsequent push.

Comment thread CHANGELOG.md Outdated
@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Updating sentry-cli.properties to version 2.0.4 will break CI tests in workflow-tests.yml which hardcode an expectation for version 2.0.0.
Severity: HIGH

Suggested Fix

Update the hardcoded version assertions in .github/workflows/workflow-tests.yml. Change the lines $env:ORIGINAL_TAG | Should -Be "2.0.0" in the updater-pr-creation and updater-target-branch jobs to expect 2.0.4. Alternatively, revert the change to updater/tests/sentry-cli.properties as it is a test fixture intended to test updates from an older version.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: updater/tests/sentry-cli.properties#L1

Potential issue: The pull request updates the version in the test fixture
`updater/tests/sentry-cli.properties` from `2.0.0` to `2.0.4`. However, the CI workflow
tests in `.github/workflows/workflow-tests.yml` contain hardcoded assertions that expect
the `originalTag` to be `2.0.0`. After this change, the updater action will correctly
read the `originalTag` as `2.0.4`, causing the PowerShell assertion `"2.0.4" Should -Be
"2.0.0"` to fail in both the `updater-pr-creation` and `updater-target-branch` jobs.
This will break the build.

Also affects:

  • .github/workflows/workflow-tests.yml

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0fc5c11. Configure here.

@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump breaks hardcoded CI test assertions

Medium Severity

Changing version from 2.0.0 to 2.0.4 in this test fixture breaks the CI workflow tests in .github/workflows/workflow-tests.yml. Two test jobs (updater-pr-creation and updater-target-branch) hardcode $env:ORIGINAL_TAG | Should -Be "2.0.0". After this change, the updater would read 2.0.4 as the original tag, failing those assertions. Additionally, if 2.0.4 is the latest 2.0.x release, no PR would be created at all, causing further test failures. The fixture is intentionally pinned at 2.0.0 so the updater always has something to update.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0fc5c11. Configure here.

@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The CI workflow in .github/workflows/workflow-tests.yml has hardcoded assertions for version "2.0.0", but the test data in sentry-cli.properties was updated to "2.0.4".
Severity: MEDIUM

Suggested Fix

Update the hardcoded version strings in the test assertions within .github/workflows/workflow-tests.yml (lines 49 and 99) from "2.0.0" to "2.0.4" to match the updated version in updater/tests/sentry-cli.properties. Alternatively, modify the workflow to use the originalTag output directly in the assertions instead of a hardcoded value.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: updater/tests/sentry-cli.properties#L1

Potential issue: The test data file `updater/tests/sentry-cli.properties` was updated to
set the version to `2.0.4`. However, the CI workflow in
`.github/workflows/workflow-tests.yml` reads this version into an `originalTag` output
but then uses hardcoded assertions in two test steps (lines 49 and 99) that expect the
`originalTag` to be `"2.0.0"`. This discrepancy will cause these assertions to fail,
breaking the CI tests for the pull request.

Also affects:

  • .github/workflows/workflow-tests.yml

@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The CI workflow workflow-tests.yml has a hardcoded assertion expecting version 2.0.0. Updating sentry-cli.properties to 2.0.4 will cause this test to fail.
Severity: HIGH

Suggested Fix

Update the hardcoded version string in the assertions within .github/workflows/workflow-tests.yml. The line $env:ORIGINAL_TAG | Should -Be "2.0.0" should be changed to $env:ORIGINAL_TAG | Should -Be "2.0.4" in both the updater-pr-creation and updater-target-branch jobs to match the new version in sentry-cli.properties.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: updater/tests/sentry-cli.properties#L1

Potential issue: The CI workflow defined in `.github/workflows/workflow-tests.yml`
contains jobs (`updater-pr-creation` and `updater-target-branch`) that read the version
from `sentry-cli.properties` and store it in the `ORIGINAL_TAG` environment variable.
These jobs then assert that `$env:ORIGINAL_TAG` should be `"2.0.0"`. Since this pull
request updates the version in `sentry-cli.properties` to `2.0.4`, the `ORIGINAL_TAG`
will become `"2.0.4"`, causing the hardcoded assertions to fail. This will break the CI
pipeline on every subsequent push after this change is merged.

Also affects:

  • .github/workflows/workflow-tests.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants