Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
- Bump Danger JS from v13.0.4 to v13.0.5 ([#160](https://github.com/getsentry/github-workflows/pull/160))
- [changelog](https://github.com/danger/danger-js/blob/main/CHANGELOG.md#1305)
- [diff](https://github.com/danger/danger-js/compare/13.0.4...13.0.5)
- Bump WORKFLOW-TEST-DEPENDENCY-DO-NOT-MERGE from v2.0.0 to v2.0.4 ([#66](https://github.com/getsentry/github-workflows/pull/66))
- [changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md#204)
- [diff](https://github.com/getsentry/sentry-cli/compare/2.0.0...2.0.4)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test dependency changelog entry pollutes production CHANGELOG

Medium Severity

A changelog entry for WORKFLOW-TEST-DEPENDENCY-DO-NOT-MERGE is being added to the real CHANGELOG.md. This is a test fixture (located in updater/tests/sentry-cli.properties) used to validate the updater workflow itself — not a genuine dependency. The PR title explicitly says "DO-NOT-MERGE," indicating this is an auto-generated test PR that was never intended to land. Merging it would leave a confusing, nonsensical entry in the project's public changelog.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit dd8eed7. Configure here.


## 3.3.0

Expand Down
2 changes: 1 addition & 1 deletion updater/tests/sentry-cli.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Updating sentry-cli.properties to version 2.0.4 will break CI tests in workflow-tests.yml which hardcode an expectation for version 2.0.0.
Severity: HIGH

Suggested Fix

Update the hardcoded version assertions in .github/workflows/workflow-tests.yml. Change the lines $env:ORIGINAL_TAG | Should -Be "2.0.0" in the updater-pr-creation and updater-target-branch jobs to expect 2.0.4. Alternatively, revert the change to updater/tests/sentry-cli.properties as it is a test fixture intended to test updates from an older version.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: updater/tests/sentry-cli.properties#L1

Potential issue: The pull request updates the version in the test fixture
`updater/tests/sentry-cli.properties` from `2.0.0` to `2.0.4`. However, the CI workflow
tests in `.github/workflows/workflow-tests.yml` contain hardcoded assertions that expect
the `originalTag` to be `2.0.0`. After this change, the updater action will correctly
read the `originalTag` as `2.0.4`, causing the PowerShell assertion `"2.0.4" Should -Be
"2.0.0"` to fail in both the `updater-pr-creation` and `updater-target-branch` jobs.
This will break the build.

Also affects:

  • .github/workflows/workflow-tests.yml

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump breaks hardcoded CI test assertions

Medium Severity

Changing version from 2.0.0 to 2.0.4 in this test fixture breaks the CI workflow tests in .github/workflows/workflow-tests.yml. Two test jobs (updater-pr-creation and updater-target-branch) hardcode $env:ORIGINAL_TAG | Should -Be "2.0.0". After this change, the updater would read 2.0.4 as the original tag, failing those assertions. Additionally, if 2.0.4 is the latest 2.0.x release, no PR would be created at all, causing further test failures. The fixture is intentionally pinned at 2.0.0 so the updater always has something to update.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0fc5c11. Configure here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The CI workflow in .github/workflows/workflow-tests.yml has hardcoded assertions for version "2.0.0", but the test data in sentry-cli.properties was updated to "2.0.4".
Severity: MEDIUM

Suggested Fix

Update the hardcoded version strings in the test assertions within .github/workflows/workflow-tests.yml (lines 49 and 99) from "2.0.0" to "2.0.4" to match the updated version in updater/tests/sentry-cli.properties. Alternatively, modify the workflow to use the originalTag output directly in the assertions instead of a hardcoded value.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: updater/tests/sentry-cli.properties#L1

Potential issue: The test data file `updater/tests/sentry-cli.properties` was updated to
set the version to `2.0.4`. However, the CI workflow in
`.github/workflows/workflow-tests.yml` reads this version into an `originalTag` output
but then uses hardcoded assertions in two test steps (lines 49 and 99) that expect the
`originalTag` to be `"2.0.0"`. This discrepancy will cause these assertions to fail,
breaking the CI tests for the pull request.

Also affects:

  • .github/workflows/workflow-tests.yml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The CI workflow workflow-tests.yml has a hardcoded assertion expecting version 2.0.0. Updating sentry-cli.properties to 2.0.4 will cause this test to fail.
Severity: HIGH

Suggested Fix

Update the hardcoded version string in the assertions within .github/workflows/workflow-tests.yml. The line $env:ORIGINAL_TAG | Should -Be "2.0.0" should be changed to $env:ORIGINAL_TAG | Should -Be "2.0.4" in both the updater-pr-creation and updater-target-branch jobs to match the new version in sentry-cli.properties.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: updater/tests/sentry-cli.properties#L1

Potential issue: The CI workflow defined in `.github/workflows/workflow-tests.yml`
contains jobs (`updater-pr-creation` and `updater-target-branch`) that read the version
from `sentry-cli.properties` and store it in the `ORIGINAL_TAG` environment variable.
These jobs then assert that `$env:ORIGINAL_TAG` should be `"2.0.0"`. Since this pull
request updates the version in `sentry-cli.properties` to `2.0.4`, the `ORIGINAL_TAG`
will become `"2.0.4"`, causing the hardcoded assertions to fail. This will break the CI
pipeline on every subsequent push after this change is merged.

Also affects:

  • .github/workflows/workflow-tests.yml

repo = https://github.com/getsentry/sentry-cli

This comment was marked as outdated.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The workflow tests have a hardcoded version check for 2.0.0, but the properties file is being updated to 2.0.4. This will cause the CI pipeline to fail.
Severity: HIGH

Suggested Fix

Update the hardcoded version string in the assertions within .github/workflows/workflow-tests.yml from 2.0.0 to 2.0.4 to match the change in the sentry-cli.properties file.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The version in `updater/tests/sentry-cli.properties` was updated from
`2.0.0` to `2.0.4`. The updater script reads this version and sets it as the
`ORIGINAL_TAG` output. However, the CI workflow tests in
`.github/workflows/workflow-tests.yml` contain hardcoded assertions that check if the
`ORIGINAL_TAG` is `2.0.0`. After this change, the `ORIGINAL_TAG` will be `2.0.4`,
causing the test assertions to fail because the value does not match the expected
`2.0.0`. This will cause the CI pipeline to fail when the pull request is merged.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The version in sentry-cli.properties was updated to 2.0.4, but the corresponding hardcoded assertions in the workflow tests still expect 2.0.0, which will cause CI failures.
Severity: MEDIUM

Suggested Fix

Update the hardcoded version string in the assertions within .github/workflows/workflow-tests.yml from "2.0.0" to "2.0.4" to match the change in updater/tests/sentry-cli.properties.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The PR updates the version in `updater/tests/sentry-cli.properties` to
`2.0.4`, but the CI workflow tests in `.github/workflows/workflow-tests.yml` contain
hardcoded assertions that expect the original version to be `2.0.0`. When the workflow
runs, it will read the new version `2.0.4` and set the `originalTag` output to this
value. This will cause the test assertion `$env:ORIGINAL_TAG | Should -Be "2.0.0"` to
fail in both the `updater-pr-creation` and `updater-target-branch` jobs, breaking the CI
pipeline.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The CI workflow has a hardcoded assertion expecting version "2.0.0", but this PR updates the test dependency to "2.0.4", which will cause the test to fail.
Severity: MEDIUM

Suggested Fix

Update the hardcoded assertions in .github/workflows/workflow-tests.yml to expect the new version "2.0.4". Specifically, change the lines $env:ORIGINAL_TAG | Should -Be "2.0.0" to $env:ORIGINAL_TAG | Should -Be "2.0.4".

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The pull request updates the version in the test dependency file
`updater/tests/sentry-cli.properties` from `2.0.0` to `2.0.4`. However, the CI workflow
in `.github/workflows/workflow-tests.yml` contains hardcoded assertions that expect the
`originalTag` output to be `"2.0.0"`. After this PR is merged, the updater action will
read `2.0.4` as the original version, causing the assertion `$env:ORIGINAL_TAG | Should
-Be "2.0.0"` to fail. This will result in a CI failure on subsequent workflow runs
triggered after the merge.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The version in updater/tests/sentry-cli.properties was updated, but the corresponding hardcoded version 2.0.0 in the CI test assertions in .github/workflows/workflow-tests.yml was not.
Severity: HIGH

Suggested Fix

Update the hardcoded version assertions in the updater-pr-creation and updater-target-branch test jobs within .github/workflows/workflow-tests.yml from "2.0.0" to "2.0.4" to match the new version in updater/tests/sentry-cli.properties.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The version in `updater/tests/sentry-cli.properties` was updated from
`2.0.0` to `2.0.4`, but the CI test assertions in `.github/workflows/workflow-tests.yml`
were not updated. The tests contain hardcoded assertions that check if the `originalTag`
is `2.0.0`. After this change is merged, the updater action will read `2.0.4` from the
properties file, causing the `originalTag` output to be `"2.0.4"`. Consequently, the
test assertion `$env:ORIGINAL_TAG | Should -Be "2.0.0"` will fail, breaking the
`updater-pr-creation` and `updater-target-branch` test jobs on every subsequent push.