Skip to content

ref(settings): convert ProjectFiltersSettings from class to function component #110201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaKGoldberg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ref(settings): convert ProjectFiltersSettings from class to function component #110201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
664ee9e
ref(settings): convert ProjectFiltersSettings from class to function …
JoshuaKGoldberg Feb 27, 2026
ee7c30d
ref: remove RowState altogether
JoshuaKGoldberg Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
214 changes: 94 additions & 120 deletions static/app/views/settings/project/projectFilters/projectFiltersSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {Component, Fragment, useCallback} from 'react';
import {Fragment, useCallback, useState} from 'react';
import {css} from '@emotion/react';
import styled from '@emotion/styled';
import iconAndroid from 'sentry-logos/logo-android.svg';
Expand Down Expand Up @@ -185,6 +185,8 @@ const LEGACY_BROWSER_SUBFILTERS = {
},
};

type LegacyBrowserSubfilterKeys = Array<keyof typeof LEGACY_BROWSER_SUBFILTERS>;

type FormFieldProps = React.ComponentProps<typeof FormField>;

type RowProps = {
Expand All @@ -193,142 +195,114 @@ type RowProps = {
};
onToggle: (
data: RowProps['data'],
filters: RowState['subfilters'],
filters: Set<string>,
event: React.MouseEvent
) => void;
disabled?: boolean;
};

type RowState = {
error: boolean | Error;
loading: boolean;
subfilters: Set<string>;
};

class LegacyBrowserFilterRow extends Component<RowProps, RowState> {
constructor(props: RowProps) {
super(props);

let initialSubfilters: any;
if (props.data.active === true) {
initialSubfilters = new Set(
Object.keys(LEGACY_BROWSER_SUBFILTERS).filter(
key =>
!LEGACY_BROWSER_SUBFILTERS[key as keyof typeof LEGACY_BROWSER_SUBFILTERS]
.legacy
)
);
} else if (props.data.active === false) {
initialSubfilters = new Set<string>();
} else {
initialSubfilters = new Set(props.data.active);
}
function getActiveSubfilters() {
return new Set(
Object.keys(LEGACY_BROWSER_SUBFILTERS).filter(
key =>
!LEGACY_BROWSER_SUBFILTERS[key as keyof typeof LEGACY_BROWSER_SUBFILTERS].legacy
)
);
}

this.state = {
loading: false,
error: false,
subfilters: initialSubfilters,
};
function getInitialSubfilters(active: boolean | string[]): Set<string> {
switch (active) {
case true:
return getActiveSubfilters();
case false:
return new Set();
default:
return new Set(active);
}
}

function LegacyBrowserFilterRow({data, disabled, onToggle}: RowProps) {
const [subfilters, setSubfilters] = useState(getInitialSubfilters(data.active));

handleToggleSubfilters = (subfilter: boolean, e: React.MouseEvent) => {
let {subfilters} = this.state;
const handleToggleSubfilters = (subfilter: boolean, e: React.MouseEvent) => {
let newSubfilters = new Set(subfilters);

if (subfilter === true) {
subfilters = new Set(
Object.keys(LEGACY_BROWSER_SUBFILTERS).filter(
key =>
!LEGACY_BROWSER_SUBFILTERS[key as keyof typeof LEGACY_BROWSER_SUBFILTERS]
.legacy
)
);
newSubfilters = getActiveSubfilters();
} else if (subfilter === false) {
subfilters = new Set();
} else if (subfilters.has(subfilter)) {
subfilters.delete(subfilter);
newSubfilters = new Set();
} else if (newSubfilters.has(subfilter)) {
newSubfilters.delete(subfilter);
} else {
subfilters.add(subfilter);
newSubfilters.add(subfilter);
}

this.setState(
{
subfilters: new Set(subfilters),
},
() => {
this.props.onToggle(this.props.data, subfilters, e);
}
);
setSubfilters(newSubfilters);
onToggle(data, newSubfilters, e);
};

render() {
const {disabled} = this.props;
return (
return (
<div>
<div>
<div>
<Flex align="center" gap="xs">
<FieldLabel disabled={disabled}>
{t('Filter out legacy browsers')}:
</FieldLabel>
<Grid flow="column" align="center" gap="md">
<Button
priority="link"
onClick={this.handleToggleSubfilters.bind(this, true)}
disabled={disabled}
>
{t('All')}
</Button>
<Button
priority="link"
onClick={this.handleToggleSubfilters.bind(this, false)}
disabled={disabled}
>
{t('None')}
</Button>
</Grid>
</Flex>
<FieldHelp>
{t(
'The browser versions filtered out will be periodically evaluated and updated.'
)}
</FieldHelp>
</div>
<FilterGrid>
{Object.keys(LEGACY_BROWSER_SUBFILTERS)
.filter(key => {
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
if (!LEGACY_BROWSER_SUBFILTERS[key].legacy) {
return true;
}
return this.state.subfilters.has(key);
})
.map(key => {
// @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message
const subfilter = LEGACY_BROWSER_SUBFILTERS[key];
return (
<FilterGridItem key={key}>
<FilterGridIcon src={subfilter.icon} />
<div>
<FilterTitle>{subfilter.title}</FilterTitle>
<FilterDescription>{subfilter.helpText}</FilterDescription>
</div>
<Switch
aria-label={`${subfilter.title} ${subfilter.helpText}`}
checked={this.state.subfilters.has(key)}
disabled={disabled}
css={css`
flex-shrink: 0;
margin-left: 6;
`}
onChange={this.handleToggleSubfilters.bind(this, key)}
size="lg"
/>
</FilterGridItem>
);
})}
</FilterGrid>
<Flex align="center" gap="xs">
<FieldLabel disabled={disabled}>{t('Filter out legacy browsers')}:</FieldLabel>
<Grid flow="column" align="center" gap="md">
<Button
priority="link"
onClick={handleToggleSubfilters.bind(undefined, true)}
disabled={disabled}
>
{t('All')}
</Button>
<Button
priority="link"
onClick={handleToggleSubfilters.bind(undefined, false)}
disabled={disabled}
>
{t('None')}
</Button>
</Grid>
</Flex>
<FieldHelp>
{t(
'The browser versions filtered out will be periodically evaluated and updated.'
)}
</FieldHelp>
</div>
);
}
<FilterGrid>
{(Object.keys(LEGACY_BROWSER_SUBFILTERS) as LegacyBrowserSubfilterKeys)
.filter(key => {
if (!LEGACY_BROWSER_SUBFILTERS[key].legacy) {
return true;
}
return subfilters.has(key);
})
.map(key => {
const subfilter = LEGACY_BROWSER_SUBFILTERS[key];
return (
<FilterGridItem key={key}>
<FilterGridIcon src={subfilter.icon} />
<div>
<FilterTitle>{subfilter.title}</FilterTitle>
<FilterDescription>{subfilter.helpText}</FilterDescription>
</div>
<Switch
aria-label={`${subfilter.title} ${subfilter.helpText}`}
checked={subfilters.has(key)}
disabled={disabled}
css={css`
flex-shrink: 0;
margin-left: 6;
`}
onChange={handleToggleSubfilters.bind(undefined, key)}
size="lg"
/>
</FilterGridItem>
);
})}
</FilterGrid>
</div>
);
}

function CustomFilters({project, disabled}: {disabled: boolean; project: Project}) {
Expand Down Expand Up @@ -448,7 +422,7 @@ export function ProjectFiltersSettings({project, params, features}: Props) {
event: React.MouseEvent;
onBlur: FormFieldProps['onBlur'];
onChange: FormFieldProps['onChange'];
subfilters: RowState['subfilters'];
subfilters: Set<string>;
}) => {
onChange?.(subfilters, event);
onBlur?.(subfilters, event);
Expand Down
Loading