fix: Prevent open redirect via double-slash path normalization#7
Open
fix: Prevent open redirect via double-slash path normalization#7
Conversation
Hono does not normalize double slashes in URL paths, so a request to /skills//evil.com produces a redirect to //evil.com, which browsers interpret as a protocol-relative URL. Use Hono's getPath constructor option to collapse consecutive slashes at the router level. Co-Authored-By: Claude <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/oruk15TIx-T3VD9E9APAKG1YnmXoIPJLuv3w7-34jj4
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hono does not normalize double slashes in URL paths (honojs/hono#3034). A request to
/skills//evil.comproducescanonicalPathof//evil.com, which browsers interpret as a protocol-relative URL — redirecting the user toevil.com.Uses Hono's
getPathconstructor option to collapse consecutive slashes at the router level, before any route matching or redirect logic runs.Agent transcript: https://claudescope.sentry.dev/share/mE64lrYaS8EVww93heEqAqoTb37x04Zc9FGcrCTg_bs