Skip to content

fix: Prevent open redirect via double-slash path normalization #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cleptric wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Prevent open redirect via double-slash path normalization #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { Hono } from "hono";
import type { Context } from "hono";
import { serve } from "@hono/node-server";
import { trimTrailingSlash } from "hono/trailing-slash";
import { getPath } from "hono/utils/url";
import type { ContentfulStatusCode } from "hono/utils/http-status";

const BASE = "https://raw.githubusercontent.com/getsentry/sentry-for-ai/refs/heads/main";
Expand Down Expand Up @@ -41,7 +42,11 @@ async function proxyText(c: Context, url: string): Promise<Response> {
}

// App
const app = new Hono();
// Hono does not normalize double slashes in paths (https://github.com/honojs/hono/issues/3034),
// which can lead to open redirects via protocol-relative URLs (e.g. //evil.com).
const app = new Hono({
getPath: (request) => getPath(request).replace(/\/+/g, "/"),
});
app.use(trimTrailingSlash({ alwaysRedirect: true }));

app.get("/", (c) => proxyText(c, `${BASE}/SKILL_TREE.md`));
Expand Down