feat: group --help flags by category, hide dev-only options#1035
feat: group --help flags by category, hide dev-only options#1035
Conversation
The Gemini smoke test has been failing on all PRs due to a missing parse_gemini_log.cjs module, causing noise in CI checks. Removing until Gemini engine support is fully implemented. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
There was a problem hiding this comment.
Pull request overview
This PR removes the Gemini smoke test workflow from the repository, deleting both the workflow definition (.md) and compiled workflow (.lock.yml) files.
Critical Issue: The PR title and description describe an entirely different set of changes (upgrading commander.js v12→v14, organizing CLI flags into groups, hiding dev-only options, and adding scripts/build-images.sh). None of these described changes are present in the actual diff. This appears to be a case of the wrong PR description being attached to these changes, or the wrong changes being committed to this PR.
Changes:
- Delete .github/workflows/smoke-gemini.md (102-line workflow definition)
- Delete .github/workflows/smoke-gemini.lock.yml (1816-line compiled workflow)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/smoke-gemini.md | Deleted entire Gemini smoke test workflow definition |
| .github/workflows/smoke-gemini.lock.yml | Deleted entire compiled Gemini smoke test workflow (auto-generated by gh-aw v0.47.0) |
Comments suppressed due to low confidence (1)
.github/workflows/smoke-gemini.md:1
- Critical discrepancy: The PR description describes upgrading commander.js from v12 to v14, organizing CLI flags into 6 groups, hiding dev-only options, shortening descriptions, and adding scripts/build-images.sh. However, the actual changes in this PR only delete the smoke-gemini workflow files. This appears to be the wrong PR description, or the wrong set of changes were committed. Please verify this is the intended change set before merging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deno Build Test Results
Overall: ✅ PASS
|
|
🤖 Smoke test results for PR #1035 ( Last 2 merged PRs:
Overall: PASS
|
Build Test: Bun Results ✅
Overall: PASS Bun version: 1.3.9
|
Build Test: Node.js Results
Overall: ✅ PASS
|
|
Smoke Test Results — PASS
|
Go Build Test Results ✅
Overall: PASS
|
.NET Build Test Results
Overall: PASS Run outputhello-world:
|
Rust Build Test Results
Overall: PASS ✅
|
C++ Build Test Results
Overall: PASS ✅
|
☕ Java Build Test Results
Overall: ✅ PASS All Java projects compiled and tested successfully via Maven through the AWF proxy.
|
|
Merged PRs: chore: remove smoke-gemini workflow
|
The flag was an escape hatch that disabled selective mounting security by adding a blanket /:/host:rw mount, exposing all credential files. It contradicts the security model and is no longer needed: - gh-aw never passes this flag (not in awf_helpers.go) - No CI workflows or smoke tests use it - It was already hidden from --help in PR #1035 - The --mount flag covers mounting specific directories Credential hiding is now unconditional — the if/else guards around selective mounting are removed, making the secure path the only path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The flag was an escape hatch that disabled selective mounting security by adding a blanket /:/host:rw mount, exposing all credential files. It contradicts the security model and is no longer needed: - gh-aw never passes this flag (not in awf_helpers.go) - No CI workflows or smoke tests use it - It was already hidden from --help in PR #1035 - The --mount flag covers mounting specific directories Credential hiding is now unconditional — the if/else guards around selective mounting are removed, making the secure path the only path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The flag was an escape hatch that disabled selective mounting security by adding a blanket /:/host:rw mount, exposing all credential files. It contradicts the security model and is no longer needed: - gh-aw never passes this flag (not in awf_helpers.go) - No CI workflows or smoke tests use it - It was already hidden from --help in PR #1035 - The --mount flag covers mounting specific directories Credential hiding is now unconditional — the if/else guards around selective mounting are removed, making the secure path the only path. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
optionsGroup()support--build-localand--allow-full-filesystem-accessfrom--help(both still work when passed — no breaking change)scripts/build-images.shas recommended dev workflow for local image buildsBefore
Flat list of 24 flags, hard to scan.
After
Test plan
npm run buildcompiles cleanlynpm test— all 800 tests passnpm run lint— 0 errorsnode dist/cli.js --helpshows grouped layout--build-local,--allow-full-filesystem-access) still parse correctly when used🤖 Generated with Claude Code