Conversation
bdf00a2 to
0e495e6
Compare
Author
|
Hi @KarmanLeung, since you recently merged a PR on this lib, maybe could you help me about this one ? Thanks |
Contributor
|
Hi @VincentLanglet, thanks for raising the issues around the phpdocs. I have updated this in the crank template and published the changes you proposed in #186 #187 #188 in the latest release v15.11.0. |
Author
Thanks a lot ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is doing multiple fixes:
are not valid PHPdoc and it reports error when using an IDE or a static-analysis tool like PHPStan
array<string, mixed>is the correct format.Related issue => #134
@methodare not used correctly.Cf https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/method.html
__callmethod, so things likeis incorrect since those method are fully implemented in the classes.
is wrong, it should be
All of these changed are in files with the following warning
but I do not have access in the
https://github.com/gocardless/crankCan anyone help me on this @barrucadu @Nimisoere @opsz2 @NickLewry ?