Fix property read syntax to supported by more tools#188
Closed
VincentLanglet wants to merge 1 commit intogocardless:masterfrom
Closed
Fix property read syntax to supported by more tools#188VincentLanglet wants to merge 1 commit intogocardless:masterfrom
VincentLanglet wants to merge 1 commit intogocardless:masterfrom
Conversation
378fbeb to
ab2d615
Compare
Author
|
Hi @KarmanLeung, since you recently merged a PR on this lib, maybe could you help me about this one ? Thanks |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is kinda similar to #186 in the idea
The issue I encountered is that the syntax
is not a valid one for lot of PHPtool, and
should be preferred instead.
Since none of the property are typed in this lib,
does the job.
As an example,
In the same way, all this files are generated by crank, so I cannot contribute to them.
Is there a way to have acces to crank or that someone move this fix to the crank library @barrucadu @Nimisoere @opsz2 @NickLewry ?
Thanks