Skip to content

Optimize Object::cast_to<T>() using Object::is_class() now that it takes a StringName #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsnopek merged 1 commit into from
May 4, 2026
+10 −18
Merged

Optimize Object::cast_to<T>() using Object::is_class() now that it takes a StringName #1974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions include/godot_cpp/core/object.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,28 +118,20 @@ class ObjectDB {

template <typename T>
T *Object::cast_to(Object *p_object) {
if (p_object == nullptr) {
return nullptr;
}
StringName class_name = T::get_class_static();
GDExtensionObjectPtr casted = ::godot::gdextension_interface::object_cast_to(p_object->_owner, ::godot::gdextension_interface::classdb_get_class_tag(class_name._native_ptr()));
if (casted == nullptr) {
return nullptr;
}
return dynamic_cast<T *>(::godot::internal::get_object_instance_binding(casted));
#if GODOT_VERSION_MINOR >= 7
return p_object && p_object->is_class(T::get_class_static()) ? static_cast<T *>(p_object) : nullptr;
#else
return p_object ? dynamic_cast<T *>(p_object) : nullptr;
#endif
}

template <typename T>
const T *Object::cast_to(const Object *p_object) {
if (p_object == nullptr) {
return nullptr;
}
StringName class_name = T::get_class_static();
GDExtensionObjectPtr casted = ::godot::gdextension_interface::object_cast_to(p_object->_owner, ::godot::gdextension_interface::classdb_get_class_tag(class_name._native_ptr()));
if (casted == nullptr) {
return nullptr;
}
return dynamic_cast<const T *>(::godot::internal::get_object_instance_binding(casted));
#if GODOT_VERSION_MINOR >= 7
return p_object && p_object->is_class(T::get_class_static()) ? static_cast<T *>(p_object) : nullptr;
#else
return p_object ? dynamic_cast<T *>(p_object) : nullptr;
#endif
}

} // namespace godot
Loading