Rename HasField::project to HasField::project_raw
#2884
Conversation
Summary of ChangesHello @jswrenn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a refactoring effort to enhance code clarity within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the HasField::project function to HasField::project_raw across the codebase. The changes are consistent with the PR title and involve updating the trait definition, its implementations, and all call sites. This is a straightforward refactoring with no functional changes.
jswrenn
force-pushed
the
Gb943ae3571a06b4a5c727268ae1829579e6350dc
branch
from
46928f4 to
9756e9d
Compare
gherrit-pr-id: Gb943ae3571a06b4a5c727268ae1829579e6350dc
jswrenn
force-pushed
the
Gb943ae3571a06b4a5c727268ae1829579e6350dc
branch
from
9756e9d to
18a7b79
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2884 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 20 20
Lines 5878 5878
=======================================
Hits 5402 5402
Misses 476 476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove high-level `HasField::project_inner`, and rename `HasField::project_raw` to `HasField::project`. The new plan is for `pointer::cast::Project` and `HasField` to only have `project` methods which project from `PtrInner<Src>` to `*mut Dst`, and for callers who want `PtrInner -> PtrInner` or `Ptr -> Ptr` to use inherent methods on `PtrInner` and `Ptr`. Compared to a default-impl'd method on `HasField`, this reduces indirection and reduces pressure on the optimizer. Reverts #2884, #2885 gherrit-pr-id: G481927cb6e9ca76c1531c05465f608e1b2607a62
3 participants
ProjectFieldtrait #2886HasField::project_inner#2885HasField::projecttoHasField::project_raw#2884Latest Update: v5 — Compare vs v4
📚 Full Patch History
Links show the diff between the row version and the column version.