Introduce HasField::project_inner

[jswrenn]

---

• Introduce ProjectField trait #2886
• Introduce HasField::project_inner #2885

Latest Update: v6 — Compare vs v5

📚 Full Patch History

Links show the diff between the row version and the column version.

Version	Base	v1	v2	v3	v4	v5
v6	vs Base	vs v1	vs v2	vs v3	vs v4	vs v5
v5	vs Base	vs v1	vs v2	vs v3	vs v4
v4	vs Base	vs v1	vs v2	vs v3
v3	vs Base	vs v1	vs v2
v2	vs Base	vs v1
v1	vs Base

[gemini-code-assist]

Summary of Changes

Hello @jswrenn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the HasField trait by introducing a new method, project_inner. This addition aims to provide a more ergonomic and safer way to project fields from a given pointer by encapsulating the raw pointer operations within a safe abstraction. It leverages the existing project_raw method and converts its output into a PtrInner type, complete with comprehensive safety comments to ensure correct memory handling and provenance.

Highlights

• New project_inner method: Introduces project_inner to the HasField trait, providing a safe abstraction for field projection. This method converts the raw pointer output of project_raw into a PtrInner type, ensuring proper provenance and non-null guarantees with detailed safety justifications.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces HasField::project_inner with a default implementation, which provides a safe wrapper around project_raw. The implementation logic is sound, but the safety comments contain minor inaccuracies regarding the argument name, which could cause confusion. I've suggested a fix to improve clarity.

[jswrenn]

@joshlf This change is a prelude to #2886, but I'm wondering if it might be of any immediate use for the cast machinery you built out.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.82%. Comparing base (ef4020b) to head (16c5cd9).

Files with missing lines	Patch %	Lines
src/lib.rs	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2885      +/-   ##
==========================================
- Coverage   91.90%   91.82%   -0.08%     
==========================================
  Files          20       20              
  Lines        5878     5883       +5     
==========================================
  Hits         5402     5402              
- Misses        476      481       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[joshlf]

Follow up with a PR that replaces uses of project_raw with uses of project_inner?