refactor(o11y): rename attributes and variables to match design#5621
Open
haphungw wants to merge 1 commit intogoogleapis:mainfrom
Open
refactor(o11y): rename attributes and variables to match design#5621haphungw wants to merge 1 commit intogoogleapis:mainfrom
haphungw wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames variables and tracing attributes from 'lro' to 'longrunning' within the aip151.rs file to align with naming conventions. Feedback suggests further updating the span name from 'LRO Wait' to 'Longrunning Wait' to maintain full consistency with the new naming scheme.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5621 +/- ##
==========================================
- Coverage 97.76% 97.76% -0.01%
==========================================
Files 221 221
Lines 51115 51113 -2
==========================================
- Hits 49973 49970 -3
- Misses 1142 1143 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haphungw
force-pushed
the
lro-tracing-clean
branch
from
ee5e7bc to
35e54e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align
google-cloud-rustimplementation with details specified in LRO Tracing design.