Fix 2

[baxyz]

• enhance SSH file synchronization
• improve error messaging for copy failures
• update version in feature configuration

Description

Please include a summary of what this PR does and why it's needed.

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update
• Refactoring
• Test improvement

Related Issues

Closes #(issue number)

How Has This Been Tested?

Describe the tests you ran and how to reproduce them:

• Test A
• Test B

Checklist

• My code follows the code style of this project
• I have updated the documentation accordingly
• I have added tests for my changes
• All new and existing tests passed locally
• My commits follow the conventional commit format

Screenshots (if applicable)

Add screenshots for UI changes.

Additional Context

Add any other context about the PR here.

[github-actions]

✅ PR Validation Passed

All checks passed!

---

📋 Pipeline Status

	Job	Status
✅	🧾 Conventional Commits	passing
✅	🧪 Feature Tests	passing
✅	🐚 ShellCheck	passing

---

_{🤖 Generated by @helpers4 CI • 2026-04-07}

[Copilot]

Pull request overview

This PR updates two devcontainer features (peon-ping and local-mounts) to improve synchronization and runtime behavior, while also bumping their published feature versions.

Changes:

• Add volume validation + more defensive JSON handling for peon-ping config/hooks generation.
• Enhance local-mounts synchronization (fallback copy strategy + broader SSH file syncing) and adjust SSH agent guidance/detection to use ssh-add -l.
• Bump feature versions for both features.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/peon-ping/install.sh	Adds volume validation and hardens JSON read/write paths; updates Copilot hook generation.
src/peon-ping/devcontainer-feature.json	Bumps peon-ping feature version to 1.0.1.
src/local-mounts/README.md	Updates SSH agent setup instructions to use ssh-add -l checks.
src/local-mounts/install.sh	Adds cp fallback logic, broadens SSH file sync, and changes runtime SSH agent socket detection.
src/local-mounts/devcontainer-feature.json	Bumps local-mounts feature version to 1.0.8.

Comments suppressed due to low confidence (3)

src/local-mounts/README.md:67

• These host-shell snippets use if ! ssh-add -l ...; then to decide whether to recreate the agent. ssh-add -l also returns non-zero when the agent is running but has no keys loaded, so this can unnecessarily kill/recreate a valid agent/socket. Consider branching on the specific “cannot connect to agent” failure case (and treating “no identities” as an alive agent).

```bash
# Stable SSH agent socket (optional, recommended for devcontainers)
export SSH_AUTH_SOCK="$HOME/.ssh/agent.sock"
if ! ssh-add -l &>/dev/null; then
    rm -f "$SSH_AUTH_SOCK"
    eval "$(ssh-agent -a "$SSH_AUTH_SOCK")" >/dev/null
    ssh-add 2>/dev/null
fi

src/local-mounts/README.md:79

• Same issue as the zsh snippet above: ssh-add -l returns non-zero when the agent is reachable but has no identities, so this condition can recreate a healthy agent/socket unnecessarily. Consider checking for the specific “cannot connect to agent” case rather than treating any non-zero as failure.

```bash
# Stable SSH agent socket (optional, recommended for devcontainers)
export SSH_AUTH_SOCK="$HOME/.ssh/agent.sock"
if ! ssh-add -l >/dev/null 2>&1; then
    rm -f "$SSH_AUTH_SOCK"
    eval "$(ssh-agent -a "$SSH_AUTH_SOCK")" > /dev/null
    ssh-add 2>/dev/null
fi

src/local-mounts/README.md:90

• Same issue as the other host-shell examples: ssh-add -l non-zero can mean “agent alive but no identities”, so this condition may recreate an agent unnecessarily (especially common before keys are added to the keychain). Consider distinguishing “cannot connect to agent” from “no identities” in the check.

```bash
export SSH_AUTH_SOCK="$HOME/.ssh/agent.sock"
if ! ssh-add -l &>/dev/null; then
    rm -f "$SSH_AUTH_SOCK"
    eval "$(ssh-agent -a "$SSH_AUTH_SOCK")" >/dev/null
    ssh-add --apple-use-keychain 2>/dev/null
fi

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.