chore(local-mounts): 🔧 update sync logic and improve documentation#17
Merged
chore(local-mounts): 🔧 update sync logic and improve documentation#17
Conversation
- move file sync to runtime via postStartCommand - add sync fallback script for shell startup - enhance README and test scripts for clarity
✅ PR Validation Passed
📋 Pipeline Status
🤖 Generated by @helpers4 CI • 2026-04-08 |
There was a problem hiding this comment.
Pull request overview
This PR updates the local-mounts devcontainer feature to sync host-mounted dotfiles at container runtime (when bind mounts are actually present), and updates documentation/tests to match the new architecture.
Changes:
- Add runtime sync script (
sync-files.sh) and run it viapostStartCommand. - Refactor
install.shto do build-time directory scaffolding + install profile.d fallback scripts. - Update README and
test/local-mounts/test.shto validate the new behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
test/local-mounts/test.sh |
Updates the feature test to validate build-time scaffolding, installed scripts, and basic runtime sync execution. |
src/local-mounts/sync-files.sh |
Adds the runtime sync implementation that copies staged mounts into the target user’s home directory. |
src/local-mounts/README.md |
Documents the new “build-time scaffolding + runtime sync + profile.d fallback” architecture and version history. |
src/local-mounts/install.sh |
Removes build-time sync logic; now creates directories/files, installs runtime sync + profile.d scripts, and writes config. |
src/local-mounts/devcontainer-feature.json |
Bumps version to 1.0.9 and adds postStartCommand to run the runtime sync script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of what this PR does and why it's needed.
Type of Change
Related Issues
Closes #(issue number)
How Has This Been Tested?
Describe the tests you ran and how to reproduce them:
Checklist
Screenshots (if applicable)
Add screenshots for UI changes.
Additional Context
Add any other context about the PR here.