-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade @storybook/builder-vite from 0.0.0-use.local to 0.1.22 #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
…rabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to resolve a medium-severity security vulnerability by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix a security vulnerability by upgrading @storybook/builder-vite. However, the proposed change from "workspace:*" to a pinned, old version "0.1.22" is incorrect for this monorepo setup. It breaks the workspace linkage and introduces a massive version downgrade, which will almost certainly break the package. Additionally, the yarn.lock file was not updated, leading to an inconsistent state. I've left a critical comment suggesting to revert this change and address the underlying vulnerability through other means, such as using yarn resolutions.
| }, | ||
| "dependencies": { | ||
| "@storybook/builder-vite": "workspace:*", | ||
| "@storybook/builder-vite": "0.1.22", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change incorrectly replaces the yarn workspace dependency workspace:* with a pinned, and very old, version 0.1.22. This will likely break the build and the functionality of this package for several reasons:
- Breaks Monorepo Link: It removes the link to the local
@storybook/builder-vitepackage within the monorepo, which is currently at version8.3.0-beta.3. Instead, it will fetch version0.1.22from the registry. - Major Version Downgrade: This is a significant downgrade from the version used in this workspace (
8.3.0-beta.3) to0.1.22. Such a large version jump backwards is almost certain to introduce breaking changes and incompatibilities. - Inconsistent Dependencies: The PR description notes that
yarn.lockfailed to update. This means the dependency tree is inconsistent and will cause issues.
While the intent is to fix a security vulnerability, this approach is incorrect and will likely cause more harm. The change should be reverted. The vulnerability in the tar package should be addressed differently, perhaps by updating the direct dependency that uses the vulnerable tar version, or by using resolutions in package.json to force a secure version of tar.
"@storybook/builder-vite": "workspace:*"
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/web-components-vite/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.