Skip to content

[Snyk] Security upgrade @storybook/builder-vite from 0.0.0-use.local to 0.1.22 #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: next
Choose a base branch
from
Open

[Snyk] Security upgrade @storybook/builder-vite from 0.0.0-use.local to 0.1.22 #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/frameworks/web-components-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/builder-vite": "workspace:*",
"@storybook/builder-vite": "0.1.22",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces the yarn workspace dependency workspace:* with a pinned, and very old, version 0.1.22. This will likely break the build and the functionality of this package for several reasons:

  1. Breaks Monorepo Link: It removes the link to the local @storybook/builder-vite package within the monorepo, which is currently at version 8.3.0-beta.3. Instead, it will fetch version 0.1.22 from the registry.
  2. Major Version Downgrade: This is a significant downgrade from the version used in this workspace (8.3.0-beta.3) to 0.1.22. Such a large version jump backwards is almost certain to introduce breaking changes and incompatibilities.
  3. Inconsistent Dependencies: The PR description notes that yarn.lock failed to update. This means the dependency tree is inconsistent and will cause issues.

While the intent is to fix a security vulnerability, this approach is incorrect and will likely cause more harm. The change should be reverted. The vulnerability in the tar package should be addressed differently, perhaps by updating the direct dependency that uses the vulnerable tar version, or by using resolutions in package.json to force a secure version of tar.

    "@storybook/builder-vite": "workspace:*"

"@storybook/web-components": "workspace:*",
"magic-string": "^0.30.0"
},
Expand Down
Loading