Skip to content

feat: carry-over Source and WHERE when navigating from Search to Chart Explorer #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MikeShi42 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: carry-over Source and WHERE when navigating from Search to Chart Explorer #1964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions packages/app/src/DBSearchPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ import {
import { notifications } from '@mantine/notifications';
import {
IconBolt,
IconChartDots,
IconPlayerPlay,
IconPlus,
IconTags,
Expand All @@ -74,6 +75,7 @@ import { useIsFetching } from '@tanstack/react-query';
import { SortingState } from '@tanstack/react-table';
import CodeMirror from '@uiw/react-codemirror';

import { DEFAULT_CHART_CONFIG } from '@/ChartUtils';
import { ContactSupportText } from '@/components/ContactSupportText';
import { DBSearchPageFilters } from '@/components/DBSearchPageFilters';
import { DBTimeChart } from '@/components/DBTimeChart';
Expand Down Expand Up @@ -1313,6 +1315,27 @@ function DBSearchPage() {
],
);

const chartExplorerUrl = useMemo(() => {
if (!searchedSource) return null;
const config = {
...DEFAULT_CHART_CONFIG,
source: searchedSource.id,
where: searchedConfig.where || '',
whereLanguage: searchedConfig.whereLanguage || 'lucene',
};
const qParams = new URLSearchParams({
config: JSON.stringify(config),
from: searchedTimeRange[0].getTime().toString(),
to: searchedTimeRange[1].getTime().toString(),
});
return `/chart?${qParams.toString()}`;
}, [
searchedSource,
searchedConfig.where,
searchedConfig.whereLanguage,
searchedTimeRange,
]);

const handleTableError = useCallback(
(error: Error | ClickHouseQueryError) => {
setIsLive(false);
Expand Down Expand Up @@ -1631,6 +1654,20 @@ function DBSearchPage() {
Alerts
</Button>
)}
{chartExplorerUrl && (
<Tooltip label="Open in Chart Explorer" withinPortal>
<ActionIcon
component="a"
href={chartExplorerUrl}
data-testid="open-in-chart-explorer-button"
variant="secondary"
size="input-xs"
style={{ flexShrink: 0 }}
>
<IconChartDots size={14} />
</ActionIcon>
</Tooltip>
)}
{!!savedSearch && (
<>
<Tags
Expand Down
Loading