Skip to content

feat: Add dashboard listing page#1971

Draft
pulpdrew wants to merge 6 commits intomainfrom
drew/dashboard-listing-page
Draft

feat: Add dashboard listing page#1971
pulpdrew wants to merge 6 commits intomainfrom
drew/dashboard-listing-page

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Mar 23, 2026

Summary

This PR introduces a new dashboards listing page, which lists the available dashboards. Each individual dashboard is no longer listed in the sidebar. The new listing page supports searching by name and filtering by tag. This PR is a continuation of @elizabetdev's #1805, with small design modifications, tests, and some refactoring.

This page does client-side sort and filter. There is no server-side pagination, filtering, or sorting. That is left as a future improvement, should it become necessary.

Further, since the "Dashboards" AppNav link now leads to the listing page, and since IS_LOCAL_MODE now supports saving dashboards (#1822), the isLocalDashboard handling has been removed.

Screenshots or video

Screenshot 2026-03-23 at 3 43 45 PM Screenshot 2026-03-23 at 3 43 36 PM Screenshot 2026-03-23 at 3 43 23 PM Screenshot 2026-03-23 at 3 43 13 PM

We also show a message about the new page, so that users will not think their dashboards have been deleted

Screenshot 2026-03-23 at 5 23 00 PM

How to test locally or on Vercel

The listing page can be tested in vercel preview

References

  • Linear Issue: Closes HDX-3788
  • Related PRs:

@vercel
Copy link

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 23, 2026 9:44pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2026

🦋 Changeset detected

Latest commit: b170c22

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

Knip - Unused Code Analysis

0 change in total issues (240 on main → 240 on PR)

Category main PR Diff
Unused files 9 9 0
Unused dependencies 14 14 0
Unused devDependencies 20 20 0
Unlisted dependencies 14 14 0
Unresolved imports 2 2 0
Unlisted binaries 2 2 0
Unused exports 132 132 0
Unused exported types 41 41 0
Unused enum members 2 2 0
Duplicate exports 4 4 0
What is this?

Knip finds unused files, dependencies, and exports in your codebase.
This comment compares the PR branch against main to detect regressions.

Run yarn knip locally to see full details.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

PR Review

  • ⚠️ DashboardsListPage.tsx is 303 lines → Project guideline (AGENTS.md) says keep files under 300 lines; extract either the empty state or the table/grid rendering into a sub-component
  • ⚠️ .changeset/tender-fans-retire.md marks this as patch → A new listing page is a user-facing feature addition and should be minor per semver
  • ℹ️ "Dashboards have moved!" message in AppNav.tsx is permanent with no dismiss/expiry → Fine for a short-term migration notice, but consider removing it after a release or two to avoid sidebar clutter

✅ No critical bugs or security issues found. Code quality is solid — good confirmation dialogs on delete, proper e.preventDefault() / e.stopPropagation() handling in the card/row menus, and comprehensive E2E coverage.

@pulpdrew pulpdrew changed the title Drew/dashboard listing page feat: Add dashboard listing page Mar 23, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

E2E Test Results

All tests passed • 98 passed • 3 skipped • 974s

Status Count
✅ Passed 98
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew force-pushed the drew/dashboard-listing-page branch from fc203a3 to b170c22 Compare March 23, 2026 21:41
@pulpdrew pulpdrew marked this pull request as draft March 23, 2026 21:53
@pulpdrew pulpdrew removed request for a team and elizabetdev March 23, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant