Skip to content

feat: Add dashboard listing page #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pulpdrew wants to merge 6 commits into
base: main
Choose a base branch
from
+1,020 −489
Draft

feat: Add dashboard listing page #1971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cf07e0c
feat: Add dashboard listing page
pulpdrew Mar 23, 2026
5fa9f84
chore: Remove isLocalDashboard handling
pulpdrew Mar 23, 2026
3e0a78d
review: Address review comments and knip findings
pulpdrew Mar 23, 2026
93059ca
test: Add E2E covering the dashboards listing page
pulpdrew Mar 23, 2026
18d6334
chore: Add message that dashboards have moved
pulpdrew Mar 23, 2026
b170c22
review: More cleanup
pulpdrew Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tender-fans-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---

feat: Add dashboard listing page
4 changes: 2 additions & 2 deletions packages/app/pages/dashboards/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
import DBDashboardPage from '@/DBDashboardPage';
export default DBDashboardPage;
import DashboardsListPage from '@/components/Dashboards/DashboardsListPage';
export default DashboardsListPage;
11 changes: 11 additions & 0 deletions packages/app/src/ClickhousePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { useEffect, useMemo, useState } from 'react';
import dynamic from 'next/dynamic';
import Link from 'next/link';
import {
parseAsFloat,
parseAsStringEnum,
Expand All @@ -16,7 +17,9 @@ import {
} from '@hyperdx/common-utils/dist/types';
import {
ActionIcon,
Anchor,
Box,
Breadcrumbs,
Button,
Grid,
Group,
Expand Down Expand Up @@ -584,6 +587,14 @@ function ClickhousePage() {

return (
<Box p="sm" data-testid="clickhouse-dashboard-page">
<Breadcrumbs mb="xs" mt="xs" fz="sm">
<Anchor component={Link} href="/dashboards" fz="sm" c="dimmed">
Dashboards
</Anchor>
<Text fz="sm" c="dimmed">
ClickHouse
</Text>
</Breadcrumbs>
<OnboardingModal requireSource={false} />
<Group justify="space-between">
<Group>
Expand Down
16 changes: 12 additions & 4 deletions packages/app/src/DBDashboardImportPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { useEffect, useRef, useState } from 'react';
import dynamic from 'next/dynamic';
import Head from 'next/head';
import Link from 'next/link';
import { useRouter } from 'next/router';
import { Controller, useForm, useWatch } from 'react-hook-form';
import { StringParam, useQueryParam } from 'use-query-params';
Expand All @@ -13,6 +14,8 @@ import {
SavedChartConfig,
} from '@hyperdx/common-utils/dist/types';
import {
Anchor,
Breadcrumbs,
Button,
Collapse,
Container,
Expand Down Expand Up @@ -508,11 +511,16 @@ function DBDashboardImportPage() {
return (
<div>
<Head>
<title>Create a Dashboard - {brandName}</title>
<title>Import Dashboard - {brandName}</title>
</Head>
<PageHeader>
<div>Create Dashboard &gt; Import Dashboard</div>
</PageHeader>
<Breadcrumbs my="lg" ms="xs" fz="sm">
<Anchor component={Link} href="/dashboards" fz="sm" c="dimmed">
Dashboards
</Anchor>
<Text fz="sm" c="dimmed">
Import
</Text>
</Breadcrumbs>
<div>
<Container>
<Stack gap="lg" mt="xl">
Expand Down
Loading
Loading