fix(orderbook): keep cancellation chainId numeric for viem EIP712Domain inference #2775
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erence Viem only includes chainId in the inferred EIP712Domain type when domain.chainId is a number or bigint. The cancellation payload was passing chainId as a string (via .toString()), which caused viem to infer EIP712Domain without chainId. That led to Guardian/go-ethereum failing with: 'there is extra data provided in the message (2 < 3)' when the domain object still contained chainId. This change normalizes chainId to a number for cancellation typed data.
|
View your CI Pipeline Execution ↗ for commit 79ce26e
☁️ Nx Cloud last updated this comment at |
JCSanPedro
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes off-chain order cancellation typed data generation in the Orderbook SDK.
Problem
prepareOrderCancellations()was settingdomain.chainIdto a string via.toString().Viem only includes
chainIdin the inferredEIP712Domaintype whendomain.chainIdis a number or bigint. When it is a string, viem infersEIP712Domainwith only:nameverifyingContract…but the
domainobject still containedchainId, which caused Guardian/go-ethereum EIP-712 hashing to fail with:Fix
Normalize
domain.chainIdtoNumber(network.chainId).Notes
order-book-mrwhich expectsEIP712Domainto includechainId.