Skip to content

fix(orderbook): keep cancellation chainId numeric for viem EIP712Domain inference #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodrigo-fournier-immutable wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(orderbook): keep cancellation chainId numeric for viem EIP712Domain inference #2775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/orderbook/src/orderbook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ export class Orderbook {
orderHash: listing.orderHash,
orderSignature: sig,
makerFees: listingParam.makerFees,
// Swallow failed creations - this gets mapped in the response to the caller as failed
// Swallow failed creations - this gets mapped in the response to the caller as failed
}).catch(() => undefined);
}),
);
Expand Down Expand Up @@ -748,7 +748,7 @@ export class Orderbook {
const network = await this.orderbookConfig.provider.getNetwork();
const domain = {
name: 'imtbl-order-book',
chainId: network.chainId.toString(),
chainId: Number(network.chainId),
verifyingContract: this.orderbookConfig.seaportContractAddress,
};

Expand Down