Skip to content

fix: plugin selection on terminal during choices prompt#429

Open
NearTox wants to merge 1 commit intoinvertase:mainfrom
NearTox:main
Open

fix: plugin selection on terminal during choices prompt#429
NearTox wants to merge 1 commit intoinvertase:mainfrom
NearTox:main

Conversation

@NearTox
Copy link
Copy Markdown

@NearTox NearTox commented Mar 24, 2026

Description

This change fixes the selection mismatch when it is launched via flutterfire install <version> vs flutterfire install --version=<version> --plugins=<plugins>

For purposes of testing, I was using flutterfire install 4.10.0 with the selecion of the plugins: firebase_core, firebase_analytics, firebase_messaging, firebase_performance, firebase_remote_config, firebase_crashlytics.

The current prompt logic ends installing firebase_in_app_messaging, firebase_ml_model_downloader instead of firebase_messaging, firebase_remote_config.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 24, 2026

CLA assistant check
All committers have signed the CLA.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the flutterfire_cli's install command. Previously, when users interactively selected Firebase plugins, the underlying logic could misinterpret their choices, leading to the installation of unintended plugins. The changes ensure that the interactive prompt accurately reflects and installs the plugins chosen by the user, improving the reliability and correctness of the flutterfire install workflow.

Highlights

  • Plugin selection accuracy: The logic for identifying and pre-selecting default plugins in the flutterfire install command was refined to ensure that the correct FlutterFirePlugins objects are used, preventing mismatches between displayed names and actual plugin instances.
  • Interactive prompt handling: The promptMultiSelect function now correctly uses a separate list of displayNames for the user interface while mapping the selected indices back to the original choices list of FlutterFirePlugins objects, resolving an issue where incorrect plugins were installed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in the install command's interactive plugin selection prompt. The issue caused a mismatch between the selected plugins and the ones actually installed. This happened because an index from a filtered list of available plugins was being used to access the complete, unfiltered list of all plugins. The fix correctly retrieves the selected plugin using the index on the filtered list. The changes are accurate and resolve the bug effectively.

@NearTox NearTox changed the title [flutterfire_cli] fix plugin selection on terminal during choices prompt fix: plugin selection on terminal during choices prompt Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants