Skip to content

fix: plugin selection on terminal during choices prompt #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NearTox wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: plugin selection on terminal during choices prompt #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/flutterfire_cli/lib/src/commands/install.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,15 +144,15 @@ class InstallCommand extends FlutterFireCommand {
.where(
(element) => listAvailablePluginsInVersion.contains(element.name),
)
.map((plugin) => plugin.displayName)
.toList();
final displayNames = choices.map((plugin) => plugin.displayName).toList();
final defaultSelection = List<bool>.filled(choices.length, false);
for (final dependency in flutterApp!.package.dependencies) {
final enumValue = FlutterFirePlugins.values.firstWhereOrNull(
final enumValue = choices.firstWhereOrNull(
(element) => element.name == dependency,
);
if (enumValue != null) {
final index = choices.indexOf(enumValue.displayName);
final index = choices.indexOf(enumValue);
defaultSelection[index] = true;
}
}
Expand All @@ -161,11 +161,12 @@ class InstallCommand extends FlutterFireCommand {

final selectedChoices = promptMultiSelect(
'Select the Firebase plugins you would like to install',
choices,
displayNames,
defaultSelection: defaultSelection,
);
for (final index in selectedChoices) {
selectedPlugins.add(FlutterFirePlugins.values[index]);
// retrieve plugin based on the choices list
selectedPlugins.add(choices[index]);
}
return selectedPlugins;
}
Expand Down
Loading