refactor: extract bootstrapAnnotationKey helper function#233
refactor: extract bootstrapAnnotationKey helper function#233Shreya2005-2005 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Duplicate fmt.Sprintf format string existed in isBootstrapCompleted and markBootstrapCompleted. Extract into bootstrapAnnotationKey(ruleName) to prevent silent divergence if one is updated independently. Fixes kubernetes-sigs#232 Signed-off-by: Shreya2005-2005 <bhakatmistu2005@gmail.com>
|
Invalid commit message issues detected Invalid commit messagesKeywords which can automatically close issues and hashtag(#) mentions are not allowed.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
✅ Deploy Preview for node-readiness-controller canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shreya2005-2005 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Shreya2005-2005. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ajaysundark review it whenever you get a chance |
Description
The annotation key format string for bootstrap completion tracking was
duplicated in isBootstrapCompleted and markBootstrapCompleted in
internal/controller/node_controller.go. Extract into a single
bootstrapAnnotationKey(ruleName string) helper function to prevent
silent divergence if one is updated independently.
Related Issue
Fixes #232
Type of Change
/kind cleanup
Testing
Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?