Skip to content

refactor: extract bootstrapAnnotationKey helper function #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Shreya2005-2005 wants to merge 1 commit into from
Closed

refactor: extract bootstrapAnnotationKey helper function #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions internal/controller/node_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,22 +317,28 @@ func (r *RuleReadinessController) removeTaintBySpec(ctx context.Context, node *c
}

// Bootstrap completion tracking.
// bootstrapAnnotationKey returns the annotation key used to track bootstrap
// completion for a given rule.
func bootstrapAnnotationKey(ruleName string) string {
return fmt.Sprintf("readiness.k8s.io/bootstrap-completed-%s", ruleName)
}

func (r *RuleReadinessController) isBootstrapCompleted(ctx context.Context, nodeName, ruleName string) bool {
// Check node annotation
node := &corev1.Node{}
if err := r.Get(ctx, client.ObjectKey{Name: nodeName}, node); err != nil {
return false
}

annotationKey := fmt.Sprintf("readiness.k8s.io/bootstrap-completed-%s", ruleName)
annotationKey := bootstrapAnnotationKey(ruleName)
_, exists := node.Annotations[annotationKey]
return exists
}

func (r *RuleReadinessController) markBootstrapCompleted(ctx context.Context, nodeName, ruleName string) {
log := ctrl.LoggerFrom(ctx)

annotationKey := fmt.Sprintf("readiness.k8s.io/bootstrap-completed-%s", ruleName)
annotationKey := bootstrapAnnotationKey(ruleName)
marked := false

// retry to handle conflict with concurrent node updates
Expand Down