use bddisasm replace capstone by rmjskhy · Pull Request #107 · lat-opensource/lat

rmjskhy · 2025-08-06T03:05:34Z

No description provided.

Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn> Change-Id: I73ad9c460459d1ddefb553f9de4727dce97baf3b

Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

…anslating fild with option_softfpu=2 Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

Use --enable-decode-debug to choose the disassembler used for each instruction. Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

Copilot

Pull Request Overview

This pull request replaces the Capstone disassembly library with bddisasm across the LATX translator-bd module. The change involves adding new translation files for different x86 instruction categories and updating build configuration to use the bddisasm library instead of Capstone.

Key Changes:

Complete replacement of Capstone disassembly with bddisasm
Addition of new translator-bd files implementing instruction translation for arithmetic, bit manipulation, control flow, and SIMD operations
Update of helper function references to use bddisasm-compatible variants
Addition of new build configuration for the translator-bd module

Reviewed Changes

Copilot reviewed 59 out of 90 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
target/i386/latx/translator-bd/tr-eflag-bd.c	Implements x86 flag manipulation instructions (popf, pushf, clc, etc.)
target/i386/latx/translator-bd/tr-btx-bd.c	Handles bit test and manipulation instructions with lock support
target/i386/latx/translator-bd/tr-bmi-bd.c	Implements bit manipulation instructions (pext, pdep, bextr, etc.)
target/i386/latx/translator-bd/tr-arith-bd.c	Contains arithmetic instruction translations (add, sub, mul, div, etc.)
target/i386/latx/translator-bd/tr-adx-bd.c	Implements ADX instruction set (adcx, adox)
target/i386/latx/translator-bd/runtime-trace-bd.c	Runtime tracing functionality with bddisasm integration
target/i386/latx/translator-bd/reg-alloc-bd.c	Register allocation updates for pattern matching support
target/i386/latx/translator-bd/meson.build	Build configuration for new translator-bd module
target/i386/latx/translator-bd/mem-interface-bd.c	Memory operand conversion with immediate caching optimization
target/i386/latx/translator-bd/macro-helper-bd.c	Helper function updates for bddisasm compatibility
target/i386/latx/sbt/aot.c	Updates helper function references for bddisasm

Copilot · 2025-08-06T03:29:31Z

target/i386/latx/translator-bd/tr-arith-bd.c

+    la_label(label_exit);
+    store_ireg_to_ir1_bd(new_eax, reg_al, false);
+    generate_eflag_calculation_bd(new_eax, old_eax, old_eax, pir1, true);
+


The variable 'temp_opnd' is allocated but never freed, causing a memory leak. Add 'ra_free_temp(temp_opnd);' before freeing n4095_opnd.

Suggested change

ra_free_temp(temp_opnd);

Copilot · 2025-08-06T03:29:31Z

target/i386/latx/translator-bd/tr-arith-bd.c

+    store_ireg_to_ir1_bd(ah, reg_ah, false);
+    store_ireg_to_ir1_bd(al, reg_al, false);
+
+    generate_eflag_calculation_bd(al, old_al, imm_opnd, pir1, true);


The variable 'ah' and 'old_al' are allocated but never freed, causing memory leaks. Add appropriate ra_free_temp calls before the return statement.

Suggested change

generate_eflag_calculation_bd(al, old_al, imm_opnd, pir1, true);

generate_eflag_calculation_bd(al, old_al, imm_opnd, pir1, true);

ra_free_temp(old_al);

ra_free_temp(ah);

Copilot · 2025-08-06T03:29:32Z

target/i386/latx/translator-bd/tr-arith-bd.c

+    la_andi(temp_opnd, ax, 0xf);
+    store_ireg_to_ir1_bd(ax, reg_ax, false);
+    store_ireg_to_ir1_bd(temp_opnd, reg_al, false);
+


The variables 'temp_opnd' and 'imm_opnd' are allocated but never freed, causing memory leaks. Add appropriate ra_free_temp calls before freeing n4095_opnd.

Suggested change

ra_free_temp(temp_opnd);

ra_free_temp(imm_opnd);

Copilot · 2025-08-06T03:29:32Z

target/i386/latx/translator-bd/tr-bmi-bd.c

+    la_label(label_exit);
+    /* 3. store result */
+    store_ireg_to_ir1_bd(result_opnd, ir1_get_opnd_bd(pir1, 0), false);
+    ra_free_temp(result_opnd);


Multiple temp variables (temp1_opnd, temp2_opnd, temp3_opnd, mask_opnd) are allocated but never freed, causing memory leaks. Add appropriate ra_free_temp calls before the return statement.

Suggested change

ra_free_temp(result_opnd);

ra_free_temp(result_opnd);

ra_free_temp(mask_opnd);

ra_free_temp(temp1_opnd);

ra_free_temp(temp2_opnd);

ra_free_temp(temp3_opnd);

Copilot · 2025-08-06T03:29:32Z

target/i386/latx/translator-bd/tr-bmi-bd.c

+    la_label(label_exit);
+    /* 3. store result */
+    store_ireg_to_ir1_bd(result_opnd, ir1_get_opnd_bd(pir1, 0), false);
+    ra_free_temp(result_opnd);


Multiple temp variables (temp1_opnd, temp2_opnd, temp3_opnd, temp4_opnd, mask_opnd) are allocated but never freed, causing memory leaks. Add appropriate ra_free_temp calls before the return statement.

Suggested change

ra_free_temp(result_opnd);

ra_free_temp(result_opnd);

ra_free_temp(mask_opnd);

ra_free_temp(temp1_opnd);

ra_free_temp(temp2_opnd);

ra_free_temp(temp3_opnd);

ra_free_temp(temp4_opnd);

Copilot · 2025-08-06T03:29:33Z

target/i386/latx/translator-bd/tr-bmi-bd.c

+    /* set cf = 0, of = 0 */
+    la_x86mtflag(zero_ir2_opnd, 0x21);
+    /* 3. store result */
+    store_ireg_to_ir1_bd(temp2_opnd, ir1_get_opnd_bd(pir1, 0), false);


The variable 'slt_opnd' is allocated but never freed, causing a memory leak. Add 'ra_free_temp(slt_opnd);' before the return statement.

Suggested change

store_ireg_to_ir1_bd(temp2_opnd, ir1_get_opnd_bd(pir1, 0), false);

store_ireg_to_ir1_bd(temp2_opnd, ir1_get_opnd_bd(pir1, 0), false);

ra_free_temp(slt_opnd);

Copilot · 2025-08-06T03:29:33Z

target/i386/latx/translator-bd/tr-adx-bd.c

+    }
+    la_x86mtflag(flag_opnd, 0x3e); //cf is not recovered
+
+    store_ireg_to_ir1_bd(temp1_opnd, ir1_get_opnd_bd(pir1, 0), false);


Multiple temp variables (flag_opnd, cflag_opnd, temp1_opnd) are allocated but never freed, causing memory leaks. Add appropriate ra_free_temp calls before the return statement.

Suggested change

store_ireg_to_ir1_bd(temp1_opnd, ir1_get_opnd_bd(pir1, 0), false);

store_ireg_to_ir1_bd(temp1_opnd, ir1_get_opnd_bd(pir1, 0), false);

ra_free_temp(flag_opnd);

ra_free_temp(cflag_opnd);

ra_free_temp(temp1_opnd);

Copilot · 2025-08-06T03:29:33Z

target/i386/latx/translator-bd/tr-adx-bd.c

+    la_bstrins_d(flag_opnd, oflag_opnd, 11, 11);
+    la_x86mtflag(flag_opnd, 0x3f);
+
+    store_ireg_to_ir1_bd(temp1_opnd, ir1_get_opnd_bd(pir1, 0), false);


Multiple temp variables (flag_opnd, oflag_opnd, temp1_opnd) are allocated but never freed, causing memory leaks. Add appropriate ra_free_temp calls before the return statement.

Suggested change

store_ireg_to_ir1_bd(temp1_opnd, ir1_get_opnd_bd(pir1, 0), false);

store_ireg_to_ir1_bd(temp1_opnd, ir1_get_opnd_bd(pir1, 0), false);

ra_free_temp(flag_opnd);

ra_free_temp(oflag_opnd);

ra_free_temp(temp1_opnd);

Copilot · 2025-08-06T03:29:33Z

target/i386/latx/translator-bd/tr-btx-bd.c

+    la_label(label_1);
+    la_ori(src_opnd, src_opnd, 0xff);
+    la_label(label_2);
+    store_ireg_to_ir1_bd(src_opnd, &eax_ir1_opnd_bd, false);


The variable 'flag_opnd' is allocated but never freed, causing a memory leak. Add 'ra_free_temp(flag_opnd);' before the return statement.

Suggested change

store_ireg_to_ir1_bd(src_opnd, &eax_ir1_opnd_bd, false);

store_ireg_to_ir1_bd(src_opnd, &eax_ir1_opnd_bd, false);

ra_free_temp(flag_opnd);

Copilot · 2025-08-06T03:29:34Z

target/i386/latx/translator-bd/tr-eflag-bd.c

+        la_bstrpick_d(esp_opnd, esp_opnd, 31, 0);
+    }
+#endif
+    la_store_addrx(temp, esp_opnd, -sp_step);


The variable 'temp' is allocated and used but never freed, causing a memory leak. Add 'ra_free_temp(temp);' after line 79.

Suggested change

la_store_addrx(temp, esp_opnd, -sp_step);

la_store_addrx(temp, esp_opnd, -sp_step);

ra_free_temp(temp);

rmjskhy added 9 commits August 6, 2025 10:59

LATX, opt: add insts pattern

11d08eb

Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn> Change-Id: I73ad9c460459d1ddefb553f9de4727dce97baf3b

Lat: Some instructions are decoded using bddisasm.

b997aae

Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

Lat: all instructions are decoded using bddisasm.

98bea92

Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

Lat: Fixed some errors found during the build process.

8a44e46

Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

Lat: Fixed inst pattern error after using bddisasm.

01a8c41

Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

Latx: Fixed an issue where the register content was incorrect when tr…

aef38ef

…anslating fild with option_softfpu=2 Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

Latx: fix err of ir1_opnd_base_reg_num_bd

7d5837d

Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

Latx: eliminate some compile-time warnings.

91dc7c1

Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

Latx: Set the default disassembler to BDDISASM.

a8a3be1

Use --enable-decode-debug to choose the disassembler used for each instruction. Signed-off-by: liuchaoyi <liuchaoyi@loongson.cn>

specialpointcentral requested a review from Copilot August 6, 2025 03:27

Copilot AI reviewed Aug 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use bddisasm replace capstone#107

use bddisasm replace capstone#107
rmjskhy wants to merge 9 commits intolat-opensource:masterfrom
rmjskhy:bddisasm

rmjskhy commented Aug 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Copilot AI Aug 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-    ra_free_temp(result_opnd);
+    ra_free_temp(result_opnd);
+    ra_free_temp(mask_opnd);
+    ra_free_temp(temp1_opnd);
+    ra_free_temp(temp2_opnd);
+    ra_free_temp(temp3_opnd);

	store_ireg_to_ir1_bd(temp2_opnd, ir1_get_opnd_bd(pir1, 0), false);
	store_ireg_to_ir1_bd(temp2_opnd, ir1_get_opnd_bd(pir1, 0), false);
	ra_free_temp(slt_opnd);

	store_ireg_to_ir1_bd(src_opnd, &eax_ir1_opnd_bd, false);
	store_ireg_to_ir1_bd(src_opnd, &eax_ir1_opnd_bd, false);
	ra_free_temp(flag_opnd);

	la_store_addrx(temp, esp_opnd, -sp_step);
	la_store_addrx(temp, esp_opnd, -sp_step);
	ra_free_temp(temp);

Conversation

rmjskhy commented Aug 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants