feat: check indentation of doc-strings, basic version#27898
Closed
grunweg wants to merge 41 commits into
Closed
Conversation
because a paragraph break has (small) semantic meaning: please double-check!
4 tasks
PR summary 218e764a49Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
There is no need for five or four when two will do equally well. This also avoids warnings from the linter in ... Arguably, these could be wrapped in code blocks instead. Should they?
30378b8 to
5deeb53
Compare
1 task
f596272 to
51d0ebe
Compare
Collaborator
Collaborator
|
This pull request has conflicts, please merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
This is rendered better on the generated documentation, and indicates that this code has different formatting rules. Found by the linter in #27898.
staroperator
pushed a commit
to staroperator/mathlib4
that referenced
this pull request
Aug 8, 2025
…nity#27901) This is rendered better on the generated documentation, and indicates that this code has different formatting rules. Found by the linter in leanprover-community#27898.
Collaborator
|
This pull request has conflicts, please merge |
Collaborator
|
This pull request has conflicts, please merge |
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…nity#27901) This is rendered better on the generated documentation, and indicates that this code has different formatting rules. Found by the linter in leanprover-community#27898.
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…nity#27901) This is rendered better on the generated documentation, and indicates that this code has different formatting rules. Found by the linter in leanprover-community#27898.
Collaborator
|
This pull request has conflicts, please merge |
Contributor
Author
|
Let's close this in favour of #27897, and re-do the doc-string fixes again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic version of #27897 (which still has some false positives): let's land this before weeding out the other errors.