Skip to content

[Merged by Bors] - chore(Tactic): move StacksAttribute to CrossRefAttribute#39257

Closed
jcommelin wants to merge 2 commits into
leanprover-community:masterfrom
jcommelin:crossref
Closed

[Merged by Bors] - chore(Tactic): move StacksAttribute to CrossRefAttribute#39257
jcommelin wants to merge 2 commits into
leanprover-community:masterfrom
jcommelin:crossref

Conversation

@jcommelin
Copy link
Copy Markdown
Member

This PR moves StacksAttribute.lean to CrossRefAttribute.lean
both in Mathlib/Tactic/ and in MathlibTest/.

In the future, we can refactor the file to abstract over the type of
cross-references. Currently, cross-reference attributes are implemented
for the Stacks Project and Kerodon.
A good candidate for a future PR is to add an attribute for Wikidata
identifiers.


Open in Gitpod

This PR moves StacksAttribute.lean to CrossRefAttribute.lean
both in Mathlib/Tactic/ and in MathlibTest/.

In the future, we can refactor the file to abstract over the type of
cross-references. Currently, cross-reference attributes are implemented
for the Stacks Project and Kerodon.
A good candidate for a future PR is to add an attribute for Wikidata
identifiers.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

PR summary 53f8a93a77

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Tactic.StacksAttribute -54
Mathlib.Tactic.CrossRefAttribute 54

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

note: file MathlibTest/StacksAttribute.lean` was renamed to `MathlibTest/CrossRefAttribute.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/Tactic/StacksAttribute.lean` was renamed to `Mathlib/Tactic/CrossRefAttribute.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

@github-actions github-actions Bot added the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label May 12, 2026
@adomani
Copy link
Copy Markdown
Contributor

adomani commented May 12, 2026

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented May 12, 2026

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label May 12, 2026
@jcommelin jcommelin added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label May 12, 2026
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented May 12, 2026

Thanks for getting this started!
In my PR, I went to the name "DatabaseAttributes". I don't think that's better than this one, though.

@mathlib-auto-merge
Copy link
Copy Markdown

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request May 12, 2026
This PR moves StacksAttribute.lean to CrossRefAttribute.lean
both in Mathlib/Tactic/ and in MathlibTest/.

In the future, we can refactor the file to abstract over the type of
cross-references. Currently, cross-reference attributes are implemented
for the Stacks Project and Kerodon.
A good candidate for a future PR is to add an attribute for Wikidata
identifiers.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented May 12, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Tactic): move StacksAttribute to CrossRefAttribute [Merged by Bors] - chore(Tactic): move StacksAttribute to CrossRefAttribute May 12, 2026
@mathlib-bors mathlib-bors Bot closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). file-removed A Lean module was (re)moved without a `deprecated_module` annotation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants