Merged
Conversation
iamfj
force-pushed
the
feat/comments-edit-reply-delete
branch
from
75affd7 to
748f39e
Compare
iamfj
force-pushed
the
feat/comments-edit-reply-delete
branch
2 times, most recently
from
b6384d5 to
73138d9
Compare
Expand CommentFields fragment with editedAt, parentId, and user. Add ListComments query, UpdateComment and DeleteComment mutations. Part of #15
…teComment Refactor createComment to use codegen types (CreatedComment). Add type aliases: CreatedComment, UpdatedComment, CommentListItem. Part of #15
- list <issue>: paginated comment listing with --limit and --after - reply <comment>: create a threaded reply to a comment - edit <comment>: update a comment's body - delete <comment>: permanently delete a comment - Updated COMMENTS_META with new arguments and description Closes #15
iamfj
force-pushed
the
feat/comments-edit-reply-delete
branch
from
73138d9 to
87f8737
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand the
commentsdomain from create-only to full CRUD + reply: addlist,reply,edit, anddeletesubcommands.Closes #15
Changes
GraphQL Layer
CommentFieldsfragment witheditedAt,parentId, anduserUpdateCommentandDeleteCommentmutationsListCommentsquery with pagination supportService Layer
createCommentto use codegen types (CreatedComment)CreatedComment,UpdatedComment,CommentListItemlistComments— paginated comment listing for an issuereplyToComment— threaded reply viaparentIdupdateComment— edit comment bodydeleteComment— permanent deletionCommand Layer
comments list <issue>— paginated listing with--limitand--aftercomments reply <comment>— reply to a comment with--bodycomments edit <comment>— update body with--bodycomments delete <comment>— delete by UUIDCOMMENTS_METAwith new arguments and descriptionTests
Architecture
No new resolvers needed — comment IDs are UUID-only. The existing
createCommentmutation is reused for replies (viaparentId). All new functions follow the established layer contract: services useGraphQLClientonly, commands delegate throughcreateContext().Verification
npm run check:ci✅npx tsc --noEmit✅npm test— 212 tests passed ✅npm run build✅