upcoming: [UIE-8515] - DBaaS: Advanced Configuration - Drawer with existing configs by mpolotsk-akamai · Pull Request #11812 · linode/manager

mpolotsk-akamai · 2025-03-10T12:48:33Z

Description 📝

Advanced Configuration - Drawer with existing configurations

Changes 🔄

List any change(s) relevant to the reviewer.

Implemented UI for the existing engine options in the drawer
Handled various types of configuration fields: text input, number input, select box, and checkbox
Added mock data for the GET request to retrieve all configurations
Managed form state with initial values

Target release date 🗓️

04/08/25

Preview 📷

Before(Figma template)	After

How to test 🧪

Prerequisites

(How to setup test environment)

Database Advanced Config feature flag should be enabled

Verification steps

(How to verify changes)

select a database cluster
navigate to the Advanced Configuration Tab
use mock data to see table with existing configurations
click 'Configure' button
drawer with all existing configurations is shown, button 'Save and Restart Service' is disabled
change the configuration
button 'Save and Restart Service' is enabled

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All unit tests are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

github-actions · 2025-03-10T13:31:30Z

Coverage Report: ✅
Base Coverage: 79.82%
Current Coverage: 79.84%

packages/api-v4/src/databases/types.ts

corya-akamai · 2025-03-10T21:09:11Z

packages/manager/src/factories/databases.ts

-      group_concat_max_len: 4,
-      information_schema_stats_expiry: 900,
      innodb_print_all_deadlocks: true,
+      service_log: false,


DBaaS is a good candidate to move to the new mock service. Is there a ticket/scope for it?

...tabases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseAdvancedConfigurationDrawer.tsx

packages/manager/src/queries/databases/databases.ts

…ng configs

…ineConfig` request to fetch all advanced configurations and updated types for advanced configs

… engine options in the drawer

cpathipa

@mpolotsk-akamai Confirming on the verification steps. Left comments to use alias tokens

cpathipa · 2025-03-14T15:57:06Z

...atabases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseAdvancedConfiguration.style.ts

+export const GroupHeader = styled('div')(({ theme }) => ({
+  background:
+    theme.palette.mode === 'dark'
+      ? theme.tokens.color.Neutrals[90]
+      : theme.tokens.color.Neutrals[5],
+  color:
+    theme.palette.mode === 'dark'
+      ? theme.tokens.color.Neutrals[5]
+      : theme.tokens.color.Neutrals[100],
+  font: theme.tokens.typography.Label.Bold.Xs,
+  padding: '8px 12px',
+  position: 'sticky',
+  textTransform: 'uppercase',
+  top: 0,
+  zIndex: 1,
+}));
+export const GroupItems = styled('ul')(({ theme }) => ({
+  '& li': {
+    color:
+      theme.palette.mode === 'dark'
+        ? theme.tokens.color.Neutrals[5]
+        : theme.tokens.color.Neutrals[100],
+    font: theme.tokens.typography.Label.Regular.Xs,
+  },


Wondering where these (GroupHeader and GroupItems) are being referenced ?

Thank you for the review!

This will be used for 'Add configuration' Autocomplete. I had to split the second PR into two parts because it was too large, so the rest will be in the next PR.

...es/Databases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseConfigurationItem.style.ts

cpathipa · 2025-03-17T15:09:33Z

...atabases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseAdvancedConfiguration.style.ts

+  background:
+    theme.palette.mode === 'dark'
+      ? theme.tokens.color.Neutrals[90]
+      : theme.tokens.color.Neutrals[5],
+  color:
+    theme.palette.mode === 'dark'
+      ? theme.tokens.color.Neutrals[5]
+      : theme.tokens.color.Neutrals[100],


Same, update with the respective alias tokens.

cpathipa · 2025-03-17T15:09:40Z

...atabases/DatabaseDetail/DatabaseAdvancedConfiguration/DatabaseAdvancedConfiguration.style.ts

+  font: theme.tokens.typography.Label.Bold.Xs,
+  padding: '8px 12px',
+  position: 'sticky',
+  textTransform: 'uppercase',


I will update this in the next PR, as these styles are for Autocomplete, which will be implemented in the next PR.
Thank you!

cpathipa · 2025-03-25T17:53:24Z

@mpolotsk-akamai There are some runtime errors caused by merging this token re-organization. Could you update this accordingly.

mpolotsk-akamai · 2025-03-26T08:15:16Z

@mpolotsk-akamai There are some runtime errors caused by merging this token re-organization. Could you update this accordingly.

Thanks! I've updated the PR.

linode-gh-bot · 2025-03-26T08:54:09Z

Cloud Manager UI test results

🎉 533 passing tests on test run #14 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`0 Failing`	`533 Passing`	`4 Skipped`	`102m 14s`

hasyed-akamai

Thanks @mpolotsk-akamai 🚢

…isting configs (linode#11812) * feat: [UIE-8515] - DBaaS: Advanced Configuration - Drawer with existing configs * feat: [UIE-8515] - update mock data * Added changeset: DBaaS Advanced Configurations: added `getDatabaseEngineConfig` request to fetch all advanced configurations and updated types for advanced configs * Added changeset: DBaaS Advanced Configurations: added UI for existing engine options in the drawer * upcoming: [UIE-8515] - review fix * upcoming: [UIE-8515] - style update, add link * update styles after token re-organization --------- Co-authored-by: cpathipa <119517080+cpathipa@users.noreply.github.com>

@coliu-akamai

* Move isNilOrEmpty * Move createDevicesFromStrings * Resolve TS errors in createDevicesFromStrings.text.ts * Move createStringsFromDevices * Move maybeCastToNumber * Consolidate imports * Fix TS error * Added changeset: Move ramda dependent utils * Keep DevicesAsStrings type import separate for better organization * Added changeset: Migrated ramda dependent utils to @linode/utilities package * Avoid importing from @linode/utilities from within the same package * Update packages/manager/.changeset/pr-11913-added-1742915642212.md Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com> * Update packages/manager/.changeset/pr-11913-added-1742915642212.md Co-authored-by: Purvesh Makode <pmakode@akamai.com> * Move utils changeset to correct spot * upcoming: [M3-9534] - Initial VPC Support in the `Add Network Interface` Drawer (#11887) * initial vpc and subnet select * add a shared firewallselect component * use firewall select globally * add jsdoc comments * add some testing * finish up testing for now * Added changeset: Add VPC support to the Add Network Interface Drawer * Added changeset: Added `FirewallSelect` component * Added changeset: Add test for Add Linode Interface drawer * clean up changesets * support default chips in the Firewall Select * fix spacing regression * properly handle disableClearable in the new Firewall Select * support default firewalls in the Add Interface drawer * use newer copy @coliu-akamai * fix unit test after UX tooltip changes --------- Co-authored-by: Banks Nussman <banks@nussman.us> * test: [M3-9486, M3-9487, M3-9557] - Allow Linode create tests to pass in alternative environments (#11886) * Delete redundant Linode Create SSH key test * Add "env:premiumPlans" test tag * Apply "env:premiumPlans" tag to Linode premium plan e2e test * Only require "Premium Plans" region capability for Premium Plans Linode create test * refactor: [M3-9617] - Move `doesRegionSupportFeature` to `utilities` package (#11891) * Move `doesRegionSupporFeature` to `utilities` pkg * Added changeset: Move `doesRegionSupportFeature` from `manager` to `utilities` package * Added changeset: Move `doesRegionSupportFeature` from `manager` to `utilities` package * refactor: [M3-8247] - Remove ramda from Utilities (#11861) * refactor: [M3-8247] - Remove ramda from Utilities * Add changeset * Add changeset * updated comment * increase coverage for isNilorEmpty() * feat: [UIE-8600] - IAM RBAC: add new drawer for unassigning role flow (#11893) * feat: [UIE-8600] - IAM RBAC: add new drawer for unassigning role flow * Added changeset: Add a new confirmation dialog for the unassigning role flow in IAM * fix the chip's color for dark theme * fix conflict and small improvements * upcoming: [UIE-8515] - DBaaS: Advanced Configuration - Drawer with existing configs (#11812) * feat: [UIE-8515] - DBaaS: Advanced Configuration - Drawer with existing configs * feat: [UIE-8515] - update mock data * Added changeset: DBaaS Advanced Configurations: added `getDatabaseEngineConfig` request to fetch all advanced configurations and updated types for advanced configs * Added changeset: DBaaS Advanced Configurations: added UI for existing engine options in the drawer * upcoming: [UIE-8515] - review fix * upcoming: [UIE-8515] - style update, add link * update styles after token re-organization --------- Co-authored-by: cpathipa <119517080+cpathipa@users.noreply.github.com> * Resolve merge conflict * Move createDevicesFromStrings * Move createStringsFromDevices * Avoid importing from @linode/utilities from within the same package * refactor: [M3-8247] - Remove ramda from Utilities (#11861) * refactor: [M3-8247] - Remove ramda from Utilities * Add changeset * Add changeset * updated comment * increase coverage for isNilorEmpty() * Move isNilOrEmpty * Move createDevicesFromStrings * Move createStringsFromDevices * refactor: [M3-8247] - Remove ramda from Utilities (#11861) * refactor: [M3-8247] - Remove ramda from Utilities * Add changeset * Add changeset * updated comment * increase coverage for isNilorEmpty() * Fix post merge conflict issues --------- Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com> Co-authored-by: Purvesh Makode <pmakode@akamai.com> Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com> Co-authored-by: Harsh Shankar Rao <hrao@akamai.com> Co-authored-by: aaleksee-akamai <aaleksee@akamai.com> Co-authored-by: mpolotsk-akamai <157619599+mpolotsk-akamai@users.noreply.github.com> Co-authored-by: cpathipa <119517080+cpathipa@users.noreply.github.com>

mpolotsk-akamai requested a review from a team as a code owner March 10, 2025 12:48

mpolotsk-akamai requested review from carrillo-erik and hasyed-akamai and removed request for a team March 10, 2025 12:48

github-project-automation bot added this to Cloud Manager Mar 10, 2025

github-project-automation bot moved this to Review in Cloud Manager Mar 10, 2025

mpolotsk-akamai self-assigned this Mar 10, 2025

mpolotsk-akamai added the DBaaS Relates to Database as a Service label Mar 10, 2025

mpolotsk-akamai changed the title ~~feat: [UIE-8515] - DBaaS: Advanced Configuration - Drawer with existing configs~~ upcoming: [UIE-8515] - DBaaS: Advanced Configuration - Drawer with existing configs Mar 10, 2025

cpathipa requested review from cpathipa and removed request for carrillo-erik March 10, 2025 14:13

corya-akamai reviewed Mar 11, 2025

View reviewed changes

mpolotsk-akamai added 4 commits March 12, 2025 13:37

feat: [UIE-8515] - DBaaS: Advanced Configuration - Drawer with existi…

fb80157

…ng configs

feat: [UIE-8515] - update mock data

b18cae6

Added changeset: DBaaS Advanced Configurations: added `getDatabaseEng…

0586548

…ineConfig` request to fetch all advanced configurations and updated types for advanced configs

Added changeset: DBaaS Advanced Configurations: added UI for existing…

50f0736

… engine options in the drawer

mpolotsk-akamai force-pushed the UIE-8515-drawer-existing-configs branch from b864aab to 50f0736 Compare March 12, 2025 12:47

upcoming: [UIE-8515] - review fix

1ad772d

mpolotsk-akamai requested a review from corya-akamai March 12, 2025 14:08

Merged latest changes from dev

cd428e4

cpathipa reviewed Mar 14, 2025

View reviewed changes

upcoming: [UIE-8515] - style update, add link

2f2b1a6

mpolotsk-akamai requested a review from cpathipa March 17, 2025 14:50

cpathipa approved these changes Mar 17, 2025

View reviewed changes

cpathipa added Add'tl Approval Needed Waiting on another approval! Merge Conflicts labels Mar 17, 2025

mpolotsk-akamai and others added 2 commits March 19, 2025 10:44

Merge branch 'develop' into UIE-8515-drawer-existing-configs

4b9edf3

Merge branch 'develop' into UIE-8515-drawer-existing-configs

4eae4c9

cpathipa removed the Merge Conflicts label Mar 19, 2025

mpolotsk-akamai mentioned this pull request Mar 19, 2025

upcoming: [UIE-8516] - DBaaS: Advanced Configuration (Part 2) - add/remove configs #11885

Merged

4 tasks

cpathipa added 4 commits March 19, 2025 13:59

Merge branch 'develop' into UIE-8515-drawer-existing-configs

1ff25f8

Merge branch 'develop' into UIE-8515-drawer-existing-configs

d768e29

Merge branch 'develop' into UIE-8515-drawer-existing-configs

6c8a307

Merge branch 'develop' into UIE-8515-drawer-existing-configs

a35b87d

update styles after token re-organization

9283e2e

hasyed-akamai approved these changes Mar 26, 2025

View reviewed changes

github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 26, 2025

hasyed-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 26, 2025

cpathipa merged commit 520b80c into linode:develop Mar 26, 2025
25 checks passed

github-project-automation bot moved this from Approved to Merged in Cloud Manager Mar 26, 2025

This was referenced Apr 3, 2025

Release v1.139.0 - release → staging #11960

Merged

Release v1.139.0 - staging → master #11980

Merged

Comments

Conversation

mpolotsk-akamai commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

github-actions bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

corya-akamai Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cpathipa left a comment

Choose a reason for hiding this comment

Uh oh!

cpathipa Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

mpolotsk-akamai Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cpathipa Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

cpathipa Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

mpolotsk-akamai Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

cpathipa commented Mar 25, 2025

Uh oh!

mpolotsk-akamai commented Mar 26, 2025

Uh oh!

linode-gh-bot commented Mar 26, 2025

Cloud Manager UI test results

🎉 533 passing tests on test run #14 ↗︎

Uh oh!

hasyed-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mpolotsk-akamai commented Mar 10, 2025 •

edited

Loading

github-actions bot commented Mar 10, 2025 •

edited

Loading